From owner-svn-src-head@freebsd.org  Thu Dec 10 07:46:18 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 245039D67EF;
 Thu, 10 Dec 2015 07:46:18 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au
 [211.29.132.97])
 by mx1.freebsd.org (Postfix) with ESMTP id E179F1FEE;
 Thu, 10 Dec 2015 07:46:17 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au
 (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197])
 by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id DA93C783252;
 Thu, 10 Dec 2015 18:46:07 +1100 (AEDT)
Date: Thu, 10 Dec 2015 18:46:07 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Hajimu UMEMOTO <ume@freebsd.org>
cc: Bruce Evans <brde@optusnet.com.au>, Eric van Gyzen <vangyzen@freebsd.org>, 
 src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Subject: Re: svn commit: r291994 - head/include
In-Reply-To: <ygefuzb4lpb.wl-ume@FreeBSD.org>
Message-ID: <20151210183005.M1400@besplex.bde.org>
References: <201512081609.tB8G9mfd053070@repo.freebsd.org>
 <yge1tawwei9.wl-ume@FreeBSD.org>
 <20151209173008.A828@besplex.bde.org> <ygefuzb4lpb.wl-ume@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=PfoC/XVd c=1 sm=1 tr=0
 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8
 a=kj9zAlcOel0A:10 a=P-yb_PvwX1cQtvFIzuYA:9 a=CjuIK1q_8ugA:10
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Dec 2015 07:46:18 -0000

On Thu, 10 Dec 2015, Hajimu UMEMOTO wrote:

>>>>>> On Wed, 9 Dec 2015 18:19:16 +1100 (EST)
>>>>>> Bruce Evans <brde@optusnet.com.au> said:
>
> brde> resolv.h already had massinve namespace pollution and style bugs in
> brde> its includes.  One more include of a header that is relatively clean
> brde> since it is tiny and was designed for minimising namespace pollution
> brde> makes little difference.
>
> I understood.  Thank you for your detailed explanation.
> However, I realized that r289315 changed the size of struct
> __res_state.  It broke binary backward compatibility.  I think we
> still need to revert its change in struct __res_state and move them
> into struct __res_state_ext.

I see.

Most of the pollution in resolv.h dates from 1993, so is hard to fix
now.  It was not in 4.4BSD.  In 4.4BSD, <stdio.h> was a prerequisite,
and undocumented APIs like fp_query() that used FILE were named with
leading underscores.  The ABI changes in __res_state are mostly newer
than than 1993.

Bruce