Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 03 Aug 2012 23:54:36 +0200
From:      Claude Buisson <clbuisson@orange.fr>
To:        nox@jelal.kn-bremen.de
Cc:        freebsd-multimedia@freebsd.org
Subject:   VLC 2.0.3
Message-ID:  <501C489C.1010405@orange.fr>

next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------080307070906060509000705
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I have done a few tests with VLC 2.0.3 and your patch (005), on 9.0-STABLE (svn
r236523) i386, with a port tree mainly from 2012/05/28 (of course this needed
some tweaks, as this tree does not support options ng). The build was done with
gcc 4.6.3 (lang/gcc).

No fancy test, only listening some CDs and watching some DVDs. Everything tested
was OK.

For a build with SKINS, the compilation failed with:

x11/x11_window.cpp: In constructor 'X11Window::X11Window(intf_thread_t*, \
    GenericWindow&, X11Display&, bool, bool, X11Window*, \
    GenericWindow::WindowType_t)':
x11/x11_window.cpp:202:25: error: '_POSIX_HOST_NAME_MAX' was not declared in \
    this scope

which is corrected by the attached patch. See also:

http://permalink.gmane.org/gmane.comp.video.videolan.vlc.scm/8740

Thanks for your work,

Claude Buisson

--------------080307070906060509000705
Content-Type: text/plain;
 name="patch-modules-gui-skins2-x11-x11_window.cpp"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="patch-modules-gui-skins2-x11-x11_window.cpp"

--- modules/gui/skins2/x11/x11_window.cpp.orig	2011-12-08 19:00:26.000000000 +0100
+++ modules/gui/skins2/x11/x11_window.cpp	2012-08-03 15:47:39.000000000 +0200
@@ -36,6 +36,7 @@
 #include "x11_factory.hpp"

 #include <assert.h>
+#include <limits.h>

 X11Window::X11Window( intf_thread_t *pIntf, GenericWindow &rWindow,
                       X11Display &rDisplay, bool dragDrop, bool playOnDrop,

--------------080307070906060509000705--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?501C489C.1010405>