From owner-freebsd-current@FreeBSD.ORG Fri Sep 11 23:03:16 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B721106566C for ; Fri, 11 Sep 2009 23:03:16 +0000 (UTC) (envelope-from oberman@es.net) Received: from mailgw.es.net (mail2.es.net [IPv6:2001:400:107:1::2]) by mx1.freebsd.org (Postfix) with ESMTP id 350C48FC13 for ; Fri, 11 Sep 2009 23:03:16 +0000 (UTC) Received: from ptavv.es.net (ptavv.es.net [IPv6:2001:400:910::29]) by mailgw.es.net (8.14.3/8.14.3) with ESMTP id n8BN3BJG005807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 11 Sep 2009 16:03:14 -0700 Received: from ptavv.es.net (ptavv.es.net [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id 21FB21CC37 for ; Fri, 11 Sep 2009 16:03:11 -0700 (PDT) To: current@freebsd.org Date: Fri, 11 Sep 2009 16:03:11 -0700 From: "Kevin Oberman" Message-Id: <20090911230311.21FB21CC37@ptavv.es.net> X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40, 4.0.166 definitions=2009-09-11_12:2009-09-01, 2009-09-11, 2009-09-11 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=5.0.0-0908210000 definitions=main-0909110130 Cc: Subject: Fix for /usr/src/Makefile.inc1 in 8.0? (pr conf/137483) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2009 23:03:16 -0000 Some time ago it was noticed (by both myself and others) that the conditional code to implement some of the system build options in src.conf(5) was badly broken. Several options with broke the build or just didn't work correctly. Mostly incorrect nesting of if statements in the file. b.f. has made a patch for this and submitted it some time ago to re, but I suspect that it fell through the cracks with all of the critical issues to be attended to before 8.0 is ready. The PR is conf/137483. The breakage to buildworld is unquestionable and will bite a lot of systems when 8.0 is released. The patch is pretty straight-forward. I have been using it since I started running 8.0 a couple of months ago. I know RE has a lot to do in a very short time, but I would really hope that this can be addressed. And, if it can't be done for 8.0, can someone at least commit this to HEAD so it can be MFCed to make it easier for those who hit this problem in 8.0-RELEASE? -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634 Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751