From owner-freebsd-current@FreeBSD.ORG  Sat Sep  5 00:45:51 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 92125106568B
	for <current@freebsd.org>; Sat,  5 Sep 2009 00:45:51 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (kientzle.com [66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 681298FC12
	for <current@freebsd.org>; Sat,  5 Sep 2009 00:45:51 +0000 (UTC)
Received: (from root@localhost)
	by kientzle.com (8.14.3/8.14.3) id n850jnVY044355;
	Fri, 4 Sep 2009 17:45:49 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Received: from dark.x.kientzle.com (fw2.kientzle.com [10.123.1.2])
	by kientzle.com with SMTP id gqxsjcr77kamdec85h2n9hab72;
	Fri, 04 Sep 2009 17:45:48 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <4AA1B4BC.2080306@freebsd.org>
Date: Fri, 04 Sep 2009 17:45:48 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.8.1.21) Gecko/20090601 SeaMonkey/1.1.16
MIME-Version: 1.0
To: Andrey Chernov <ache@nagual.pp.ru>, current@freebsd.org, lev@freebsd.org
References: <20090904055607.GA89117@nagual.pp.ru>
In-Reply-To: <20090904055607.GA89117@nagual.pp.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: 'svn add' does not add 'svn:keywords', but 'svn ci' ask for it
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Sep 2009 00:45:51 -0000

Andrey Chernov wrote:
> 1) svn add some_file
> 2) svn ci some_file
> svn: Commit blocked by pre-commit hook (exit code 1) with output:
> Path ".../some_file" is missing the 
> svn:keywords property (or an fbsd:nokeywords override)
> 
> I manage it adding by hand:
> 3) svn propset svn:keywords 'FreeBSD:%H' some_file
> 
> It isn't convenient. Why 'svn add' can't do it automatically for 
> me using the same detection method as 'svn ci'? 

The "svn ci" check is done on the server, and subversion
does not allow the server checks to change the commit
in any way.  The server-side hooks can only inspect
the commit and choose whether or not to permit it.

The "svn add" command doesn't talk to the server at all;
it only modifies the pending update on the local client.

As I think others have pointed out, the standard
"svn" command-line tool does have an option to
automatically set certain properties depending
on the file type.  I believe this check is only
done for "svn add."

Tim