From owner-freebsd-hackers@freebsd.org Fri May 20 12:00:15 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CAD63B438A3 for ; Fri, 20 May 2016 12:00:15 +0000 (UTC) (envelope-from ml@my.gd) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9267B16E2 for ; Fri, 20 May 2016 12:00:15 +0000 (UTC) (envelope-from ml@my.gd) Received: by mail-io0-x22d.google.com with SMTP id f8so10425514ioe.3 for ; Fri, 20 May 2016 05:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=my-gd.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=ZNjJgRgOD8gkjU3aozgATQHsATJy2ajM8KoqJmgAAI4=; b=Owp/pcq7aWqynIzwLZHxX4LmN34YY//wEdO/KrdM+RN6W1rGkQPWqSRjTTnhzXVfY0 K4flSJLp37vmRNJv+m2z7QYoFcOjLSE6WlCWW8d1d2JFa0N+OnizdnC8Md9lw0SMhebG y4gKEI81ubsz11nehMd120OO4dDYbmwU/SjbPzL0FdrvWuNiySwLU0QWClPmulzBhp5M zpI9IspLsZMEx/Yl8nvDIYRFcROubTqnh8kLkjRNkweqGfTWnVG1tjhjyFcia7/uVd/e uSv8x33ReCExJYA9xiSE2XaDr3syaKAo2d9BVIivBh15MsHb6eP27CLJ70iszak8tZEE 7FaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=ZNjJgRgOD8gkjU3aozgATQHsATJy2ajM8KoqJmgAAI4=; b=m2C/P+Q+HezX1KvCZk0ROWC2fpLBOhbl0AXy/0dUC+jqcPvDaf2HC81nd3p5p5Rb9U Ms0K8HMJ67ayFiLGakc0IZU+8PH1giruMkdzpudIt9biXqH0/bLQRkDyu477+PXfbJqx HAYO7KXTG8UHGLdyZbBtGgvtc8G0D2bFvAWUKmJPrT2O1GL0dcO9N899KA85IAqjo6Z2 8uNcm+/9Qq/padvPR3lTHixUp2ynge2h2VaznrZh9+W7ANewsI5yi8LbXOQcOyO2dWvx 3dX1xqXp4oqZSXnKWLz0ZjcaNOCoEPeJWa0TVFvHVo+aQlGqkx8D4OmZ6t0dCJmPNReV rfng== X-Gm-Message-State: AOPr4FUrmHyvQ1vXNOX/qzw0o0bXhtzWIXjoxmq0pVkDAZF3B4t7P3vwOuc5G5ZLiU2xHG4pv8dg8Z76+blLDw== MIME-Version: 1.0 X-Received: by 10.36.149.215 with SMTP id m206mr2741158itd.20.1463745611128; Fri, 20 May 2016 05:00:11 -0700 (PDT) Received: by 10.79.124.93 with HTTP; Fri, 20 May 2016 05:00:11 -0700 (PDT) In-Reply-To: <20160520113431.GW15808@e-new.0x20.net> References: <20160519041118.GE19887@gmail.com> <573D3DA7.20600@freebsd.org> <20160519212934.GF19887@gmail.com> <20160520113431.GW15808@e-new.0x20.net> Date: Fri, 20 May 2016 14:00:11 +0200 Message-ID: Subject: Re: What changes are welcome? From: Damien Fleuriot To: Lars Engels Cc: freebsd-hackers@freebsd.org, Randy Westlund , Allan Jude Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2016 12:00:15 -0000 On 20 May 2016 at 13:34, Lars Engels wrote: > On Fri, May 20, 2016 at 12:53:36PM +0200, Damien Fleuriot wrote: > > On 19 May 2016 at 23:29, Randy Westlund wrote: > > > > > On Thu, May 19, 2016 at 12:14:31AM -0400, Allan Jude wrote: > > > > Generally, you likely want to avoid changing anything from contrib/ > or > > > > vendor/, as that is code from other projects that is imported, and > local > > > > changes complicate that. Of course, top is not really maintained > > > > 'upstream' anymore, so maybe it isn't a bad place to start. > > > > > > > > Phabricator is likely the best place for patches, it is much easier > to > > > > review. > > > > > > Indeed, looks like it's been 16 years. I silenced 131 warnings. > > > > > > https://reviews.freebsd.org/D6468 > > > > > > > > > Sorry for hijacking ;) > > > > > > > > On the topic of contributing, there's a bug report I filed almost a year > > ago for net/relayd [1] > > > > The submitted change is very minor and mimics nginx's behaviour, adding a > > configuration sanity check before restarting or reloading net/relayd. > > > > > > Is there a better place for me to submit this, or would someone have the > > spare time to take a look ? > > Yes, ports@ would be a better place. :) > Yeah been there, done that... Since it's been almost a year however, I'll give it another go ;)