Date: Fri, 20 May 2016 14:00:11 +0200 From: Damien Fleuriot <ml@my.gd> To: Lars Engels <lme@freebsd.org> Cc: freebsd-hackers@freebsd.org, Randy Westlund <rwestlun@gmail.com>, Allan Jude <allanjude@freebsd.org> Subject: Re: What changes are welcome? Message-ID: <CAE63ME7uYvm4ghCL_M5AduRt_w6JDkAFCrGGs_-QX_b0z7bpkg@mail.gmail.com> In-Reply-To: <20160520113431.GW15808@e-new.0x20.net> References: <20160519041118.GE19887@gmail.com> <573D3DA7.20600@freebsd.org> <20160519212934.GF19887@gmail.com> <CAE63ME4Ubhk6ug-wM_OAncufWD4OoKLNp6QWXZGO00k4X3bQmQ@mail.gmail.com> <20160520113431.GW15808@e-new.0x20.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 May 2016 at 13:34, Lars Engels <lme@freebsd.org> wrote: > On Fri, May 20, 2016 at 12:53:36PM +0200, Damien Fleuriot wrote: > > On 19 May 2016 at 23:29, Randy Westlund <rwestlun@gmail.com> wrote: > > > > > On Thu, May 19, 2016 at 12:14:31AM -0400, Allan Jude wrote: > > > > Generally, you likely want to avoid changing anything from contrib/ > or > > > > vendor/, as that is code from other projects that is imported, and > local > > > > changes complicate that. Of course, top is not really maintained > > > > 'upstream' anymore, so maybe it isn't a bad place to start. > > > > > > > > Phabricator is likely the best place for patches, it is much easier > to > > > > review. > > > > > > Indeed, looks like it's been 16 years. I silenced 131 warnings. > > > > > > https://reviews.freebsd.org/D6468 > > > > > > > > > Sorry for hijacking ;) > > > > > > > > On the topic of contributing, there's a bug report I filed almost a year > > ago for net/relayd [1] > > > > The submitted change is very minor and mimics nginx's behaviour, adding a > > configuration sanity check before restarting or reloading net/relayd. > > > > > > Is there a better place for me to submit this, or would someone have the > > spare time to take a look ? > > Yes, ports@ would be a better place. :) > Yeah been there, done that... Since it's been almost a year however, I'll give it another go ;)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE63ME7uYvm4ghCL_M5AduRt_w6JDkAFCrGGs_-QX_b0z7bpkg>