From owner-freebsd-fs@FreeBSD.ORG Wed Sep 18 23:27:57 2013 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4936040B for ; Wed, 18 Sep 2013 23:27:57 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 154732CCC for ; Wed, 18 Sep 2013 23:27:56 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.31]) by ltcfislmsgpa01.fnfis.com (8.14.5/8.14.5) with ESMTP id r8INRphu024568 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 18 Sep 2013 18:27:51 -0500 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.202]) by LTCFISWMSGHT03.FNFIS.com ([10.132.206.31]) with mapi id 14.02.0309.002; Wed, 18 Sep 2013 18:27:50 -0500 From: "Teske, Devin" To: "Oleksandr V. Typlyns'kyi" Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?) Thread-Topic: kern/182181: [ufs] Leakage of vnode references (race condition?) Thread-Index: AQHOtMawgNcXNLXack24f2qWRmdm4w== Date: Wed, 18 Sep 2013 23:27:50 +0000 Message-ID: <13CA24D6AB415D428143D44749F57D720FBD7904@LTCFISWMSGMB21.FNFIS.com> References: <201309182300.r8IN01d6017440@freefall.freebsd.org> In-Reply-To: <201309182300.r8IN01d6017440@freefall.freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.126] Content-Type: text/plain; charset="us-ascii" Content-ID: <5C1B24DF7A32324B8E978BBF1AA48F4D@fisglobal.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794, 1.0.431, 0.0.0000 definitions=2013-09-18_09:2013-09-18,2013-09-18,1970-01-01 signatures=0 Cc: "" , "Teske, Devin" X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2013 23:27:57 -0000 On Sep 18, 2013, at 4:00 PM, Oleksandr V. Typlyns'kyi wrote: > Devin, i think line 1266 in HEAD - it is line 1245 in 8-STABLE: > http://svnweb.freebsd.org/base/head/sys/ufs/ufs/ufs_vnops.c?annotate=3D25= 3998#l1266 > http://svnweb.freebsd.org/base/stable/8/sys/ufs/ufs/ufs_vnops.c?annotate= =3D248832#l1245 > http://svnweb.freebsd.org/base/releng/8.4/sys/ufs/ufs/ufs_vnops.c?annotat= e=3D248833#l1245 > And it was not MFC'ed Yes, my confusion was... 1. The PR headers say 8.4-RELEASE-p3 is affected 2. The PR's "How-To-Repeat" starts with "Install a releng/8.4 branch" Yet... releng/8.4 and even releng/8.3 both use VOP_UNLOCK instead of vput (read: are patched). So I'm very curious, with respect to the PR, how the test program showed a leak when the claim is that r253998 which fixes this, was in the OP's bra= nch. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.