From owner-freebsd-bugs@FreeBSD.ORG  Tue Mar  4 16:21:15 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A92501065672;
	Tue,  4 Mar 2008 16:21:15 +0000 (UTC)
	(envelope-from novel@FreeBSD.org)
Received: from viefep25-int.chello.at (viefep25-int.chello.at [62.179.121.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 7E1858FC2A;
	Tue,  4 Mar 2008 16:21:14 +0000 (UTC)
	(envelope-from novel@FreeBSD.org)
Received: from novel.renet.ru ([82.116.33.234]) by viefep28-int.chello.at
	(InterMail vM.7.08.02.02 201-2186-121-104-20070414) with ESMTP
	id <20080304160502.FQKK13245.viefep28-int.chello.at@novel.renet.ru>;
	Tue, 4 Mar 2008 17:05:02 +0100
Date: Tue, 4 Mar 2008 19:08:09 +0300
From: Roman Bogorodskiy <novel@FreeBSD.org>
To: "Andrey V. Elsukov" <bu7cher@yandex.ru>
Message-ID: <20080304160809.GA73149@underworld.novel.ru>
References: <200802261908.m1QJ8n5N023371@freefall.freebsd.org>
	<47C4F2D1.5080703@yandex.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9"
Content-Disposition: inline
In-Reply-To: <47C4F2D1.5080703@yandex.ru>
X-PGP: http://people.freebsd.org/~novel/novel.key.asc
Cc: freebsd-bugs@FreeBSD.org, Luigi Rizzo <rizzo@icir.org>, araujo@FreeBSD.org,
	freebsd-ipfw@FreeBSD.org, Vadim Goncharov <vadimnuclight@tpu.ru>,
	Oleg Bulyzhin <oleg@FreeBSD.org>, Julian Elischer <julian@elischer.org>
Subject: Re: kern/121122: [ipfw] [patch] add support to ToS IP PRECEDENCE
	fields
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Mar 2008 16:21:15 -0000


--PEIAKu/WMn1b1Hv9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

  Andrey V. Elsukov wrote:

> araujo@FreeBSD.org wrote:
>> Synopsis: [ipfw] [patch] add support to ToS IP PRECEDENCE fields
>> Responsible-Changed-From-To: freebsd-bugs->freebsd-ipfw
>> Responsible-Changed-By: araujo
>> Responsible-Changed-When: Tue Feb 26 19:08:49 UTC 2008
>> Responsible-Changed-Why: Over to maintainer(s).
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D121122
>=20
> Hi, Marcelo.
>=20
> I talked to Roman when he submitted his first patch about
> it's design. What you think about making TOK_SETIPTOSPRE not
> an action, but a modifier? I think it will be much usable.
> A syntax example:
>=20
> # ipfw add allow iptospre flashover ip from any to any
> # ipfw add count iptospre immediate ip from anyt to any
> # ipfw add skipto ....
>=20
> Also I talked to Roman about extensible variant of this ability.
> A syntax example:
>=20
> <action> [{modip [DF|TOS|DSCP|TTL]}] <rule body>

I agree with you, this syntax looks cleaner, however when I was writing
my patches I just needed to have the things working and haven't had much
time improving/extending this feature.

> Also look into:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/102471
> http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/103454
>=20
> I added to CC several men who are active in ipfw area.
> It will be interested what you think about this?
>=20
> --=20
> WBR, Andrey V. Elsukov

Roman Bogorodskiy

--PEIAKu/WMn1b1Hv9
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQFHzXPn5nvOfo4+NdURAlnLAJ4vjC3dY+p7rpqmYieIwXYGh8UXlwCdG4ww
/HEHBK5HfyPkLqkGhQ4I15A=
=cpkK
-----END PGP SIGNATURE-----

--PEIAKu/WMn1b1Hv9--