From owner-svn-src-all@freebsd.org Tue Sep 3 14:08:03 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 42D76DD5CD; Tue, 3 Sep 2019 14:07:10 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N80F2QQQz4QJ0; Tue, 3 Sep 2019 14:07:09 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 86D341B170; Tue, 3 Sep 2019 14:06:29 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 755911D29C; Fri, 19 Apr 2019 18:09:53 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2AFA18AD50; Fri, 19 Apr 2019 18:09:53 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 192CE1D29A; Fri, 19 Apr 2019 18:09:53 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id EB8C11D279; Fri, 19 Apr 2019 18:09:49 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 884D88AD1D; Fri, 19 Apr 2019 18:09:49 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x444.google.com with SMTP id 9so2852643pfj.13; Fri, 19 Apr 2019 11:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=bUi1cu7Htl3Gsf7hhYKZ6yb5ttLVV3vhNIcPOJovSA4=; b=GzBbYWmXlZ4GRsuuaEYvtF85flKpQ9I0Hf+y1sbsTj++qofEAXF6vsAbODbJZvMrMK m+XBmwiPvaWJIuhnRac/SvPpjvxxd7V1grvXEIrkek7AIXr0u1z2rQPusyQGj/sboX5d M7VRn/g5Ao+OjWScEmQyiNW/PwVE5l7FJDFwS9yG1iobYxUD7nBd+BBW00iuG3/QmVED ZW+DsEtJHCriFVXrXRM5nuplz78DjFYGhqQI3PKAMyRI/hYmiJCo09YsV/pq4c9ZqvXD jROA+Cfhl1jUukzo4Xj8K1vyeLQrkhmrc56JFRgDxGihZayhlEctS57aZllzbdE+oqT0 T4nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=bUi1cu7Htl3Gsf7hhYKZ6yb5ttLVV3vhNIcPOJovSA4=; b=TA1MbeEcudhpT8CyO+5Urd8R4yaFDqcJtvvVutHI3iV/MDoTCpKXYf2VlmQNzYvxik eaB1E+V9/+QBBxcbQN3IfvSclFuKK+matjsB3HAlYTYIo53et3jsOfSawViPk4EfyiwD 4D1ngCFzMZfKfBO9LTn2O7bf0B7+TdIxS8eV4qbW+s2+un8oavTgrkAoVaD7f+ueZ3WG HHtcX58i4GUIsl3Noj4xI56TC1ReCkMhcmDRxJMsoOLe+H+I+5CzNhj9LyrzYz/awEbJ RkZd2FmFwdHvpsWl2OQ7gUwbXhL/+TD+9OW57iGz07PovIfA5ZcatA4XDFTjb1D+a8eI MOOQ== X-Gm-Message-State: APjAAAV6IDRkvAiS7F9bMJIZ0tXqKNp+D5Gx7V36rKIMbZNwlpNixW04 0SMtMKgjTPYm9G6QmiSUpDVcJqea7BA= X-Google-Smtp-Source: APXvYqxjlI7JatWvfMCnsrD8ZSzVsayUgOpg5lnZOA5WDr7dGjggjbzFN5BfXot1ZwkzGV9BtuDcdw== X-Received: by 2002:a62:2046:: with SMTP id g67mr5237676pfg.121.1555697385058; Fri, 19 Apr 2019 11:09:45 -0700 (PDT) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id z22sm5566873pgv.23.2019.04.19.11.09.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 11:09:44 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: Enji Cooper X-Mailer: iPhone Mail (16E227) In-Reply-To: <201904191544.x3JFijLe075969@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <0F708A9C-D29D-466A-B541-06DB7127349E@gmail.com> References: <201904191544.x3JFijLe075969@repo.freebsd.org> To: Alexander Motin Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 2AFA18AD50 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.93)[-0.927,0] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:08:03 -0000 X-Original-Date: Fri, 19 Apr 2019 11:09:43 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:08:03 -0000 > On Apr 19, 2019, at 08:44, Alexander Motin wrote: >=20 > Author: mav > Date: Fri Apr 19 15:44:45 2019 > New Revision: 346390 > URL: https://svnweb.freebsd.org/changeset/base/346390 >=20 > Log: > Change the way FreeBSD GID inheritance is hacked. >=20 > I believe previous ifdef caused NULL dereference in later zfs_log_create(= ) > on attempt to create file inside directory belonging to ephemeral group > created on illumos, trying to write to log information about GID domain > of the newly created file, inheriting the ephemeral GID. >=20 > This patch reuses original illumos SGID code with exception that due to > lack of ID mapping code on FreeBSD ephemeral GID will turn into GID_NOBOD= Y > by another ifdef inside zfs_fuid_map_id(). Hi mav@! I was wondering, does this break ACL mappings with sticky bits for the g= roup ID (or was it broken to begin with)? If the latter, does it make sense t= o file a bug/add a TODO comment? Thank you! -Enji=