From owner-freebsd-bugs@FreeBSD.ORG  Thu May 15 10:40:04 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 725B0106566C
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 15 May 2008 10:40:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 5FBFD8FC23
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 15 May 2008 10:40:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m4FAe4L8057924
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 15 May 2008 10:40:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m4FAe4tP057923;
	Thu, 15 May 2008 10:40:04 GMT (envelope-from gnats)
Date: Thu, 15 May 2008 10:40:04 GMT
Message-Id: <200805151040.m4FAe4tP057923@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jaakko Heinonen <jh@saunalahti.fi>
Cc: 
Subject: Re: kern/122833: [snapshots] [patch] mountd fails on nmount()
	after UFS snapshot creation with mount
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jaakko Heinonen <jh@saunalahti.fi>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 May 2008 10:40:04 -0000

The following reply was made to PR kern/122833; it has been noted by GNATS.

From: Jaakko Heinonen <jh@saunalahti.fi>
To: Craig Rodrigues <rodrigc@crodrigues.org>
Cc: bug-followup@FreeBSD.org,
	Ga??l Roualland <gael.roualland@dial.oleane.com>,
	leon.kos@lecad.fs.uni-lj.si, rodrigc@FreeBSD.org,
	Yar Tikhiy <yar@comp.chem.msu.su>
Subject: Re: kern/122833: [snapshots] [patch] mountd fails on nmount()
	after UFS snapshot creation with mount
Date: Thu, 15 May 2008 13:35:39 +0300

 Thank you for your quick response.
 
 On 2008-05-14, Craig Rodrigues wrote:
 > On Wed, May 14, 2008 at 06:56:40PM +0000, Craig Rodrigues wrote:
 > > That fix is wrong.  The better fix would be to come up
 
 Yes, I probably should have stated more clearly that it was a quick
 hack.
 
 > Actually we have such a function.  We need to do to the "snapshot" option
 > what we do to the "export" option in sys/kern/vfs_export.c.
 
 > --- ffs_vfsops.c        26 Mar 2008 20:48:07 -0000      1.340
 > +++ ffs_vfsops.c        14 May 2008 21:00:23 -0000
 
 There is also code in vfs_mount.c that sets the MNT_SNAPSHOT flag:
 (in vfs_donmount())
 		else if (strcmp(opt->name, "snapshot") == 0)
 			fsflags |= MNT_SNAPSHOT;
 
 I wonder if we should add the option removal code also there or remove
 the "snapshot" handling completely from vfs_donmount(). For me it seems
 confusing that MNT_SNAPSHOT is first set in vfs_donmount() and then
 again in file system specific code but the snapshot option string is
 removed only in file system specific code.
 
 Thanks.
 -- 
 Jaakko