From owner-svn-src-all@freebsd.org Tue Feb 12 16:45:09 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6BFC14EC8A0; Tue, 12 Feb 2019 16:45:09 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9BB326DDBB; Tue, 12 Feb 2019 16:45:07 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id tbB2gs7KH82YctbB3gZRjb; Tue, 12 Feb 2019 09:44:58 -0700 X-Authority-Analysis: v=2.3 cv=NNSrBHyg c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=CFTnQlWoA9kA:10 a=xfDLHkLGAAAA:8 a=iKhvJSA4AAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=OKdY6dQ4TF2Wvm_oR2AA:9 a=CjuIK1q_8ugA:10 a=IfaqVvZgccqrtc8gcwf2:22 a=odh9cflL3HIXMm4fY7Wr:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 855391CA; Tue, 12 Feb 2019 08:44:55 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x1CGitNP070478; Tue, 12 Feb 2019 08:44:55 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x1CGisIg070475; Tue, 12 Feb 2019 08:44:54 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201902121644.x1CGisIg070475@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: "Rodney W. Grimes" , Dmitry Morozovsky , Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r344051 - in stable/12/sbin: newfs tunefs In-Reply-To: Message from Warner Losh of "Tue, 12 Feb 2019 09:25:30 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 12 Feb 2019 08:44:54 -0800 X-CMAE-Envelope: MS4wfN0F5VjMH6/f1AwC2iE8t79lWh+ZzMCjhOHwH/xY8W1VdA4DpyZY6r7gXKfpkCB9JAVz9nfE1albHK5L6t4uGOH0/EGQw/NHzl73XTdGuJ2cv3u0GBLV eEIuPQuQx+Y5oC6iKFKnZrdt0Ff6H4xpbPBpEzaf4XjltWZeCQYC2/3NwZMOMjJCJwH7uru0qY++AVsYalx+Q+3NnV/5jJ2OhlnG/VVBJjceuyVNpK/zdmtJ ydLMB8vjaxXQYBHScKveK0UMkwfr9pti7YpHJJBcuQ5izov9wPy0cgTZm9mcgeNA0VchXo61zTAQUwe3m5BPuec2pHBpUoeF2UyO3rpGf9/TqQv46cG2LgFf FVZBcQahSnMhPNuKzXyQ1tUdwlWkaSp7DNjwbgJT2oRIFRQjLTc= X-Rspamd-Queue-Id: 9BB326DDBB X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.48 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.92)[-0.924,0]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_SPF_NA(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[139.136.59.64.list.dnswl.org : 127.0.5.1]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-1.85)[ip: (-4.67), ipnet: 64.59.128.0/20(-2.52), asn: 6327(-1.96), country: CA(-0.09)]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 16:45:10 -0000 In message , Warner Losh writes: > --000000000000583a5b0581b4e04a > Content-Type: text/plain; charset="UTF-8" > > On Tue, Feb 12, 2019 at 9:21 AM Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > On Tue, 12 Feb 2019, Cy Schubert wrote: > > > > > > > In message <201902121358.x1CDwGf9047873@repo.freebsd.org>, Dmitry > > > > Morozovsky wr > > > > ites: > > > > > Author: marck (doc committer) > > > > > Date: Tue Feb 12 13:58:16 2019 > > > > > New Revision: 344051 > > > > > URL: https://svnweb.freebsd.org/changeset/base/344051 > > > > > > > > > > Log: > > > > > MFC 343548: > > > > > > > > > > Allow dashes as a valid character in UFS labels. > > > > > > > > Approved by: Whom? > > > > > > Sorry, I missed commit log metadata from the original change. > > > > > > Lesson learnt. > > > > I think your fine on how you did this, I certainly already > > knew from reading the ^head commits that this change had > > infact been approved by Kirk, and had been flagged for MFC. > > > > I do not see value in duplicationg all that info in the > > stable branches, but perhaps we should formalize that in > > the committers guide on commit messages? > > > > Let's not overreact. Someone made a commit, someone else didn't go check > the original commit to see it was legit and asked a question. The original > bonafides were provided. Case closed. No need to make a federal case out of > it. The doc committer learned to take a little extra care on their commit > messages, it seems, as doc committers committing to src get a little extra > scrutiny. The original complainer likely noticed the info was in the > original commit and may check there in the future before complaining. Or > maybe he won't. It isn't a big deal either way. I, the original complainer, noticed a commit by a doc committer without approval by a src committer. > > None of this requires a change to the rules. Agreed. No rules need to be changed. It's not a big deal. At the time the question was about, something was missed or someone did something that they didn't have authority to do. The question was answered a couple of hours ago. We can stop bikeshedding this to try to create more rules when none are required. It was a simple, who authorized this commit? We got our answer. Let's move on. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.