From owner-trustedbsd-cvs@FreeBSD.ORG Thu Oct 5 16:04:59 2006 Return-Path: X-Original-To: trustedbsd-cvs@freebsd.org Delivered-To: trustedbsd-cvs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 042E916A415 for ; Thu, 5 Oct 2006 16:04:59 +0000 (UTC) (envelope-from owner-perforce@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 887FA43D6B for ; Thu, 5 Oct 2006 16:04:42 +0000 (GMT) (envelope-from owner-perforce@freebsd.org) Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by cyrus.watson.org (Postfix) with ESMTP id C9B3D46CB0 for ; Thu, 5 Oct 2006 12:04:41 -0400 (EDT) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 1D7A15718A; Thu, 5 Oct 2006 16:03:41 +0000 (GMT) (envelope-from owner-perforce@freebsd.org) Received: by hub.freebsd.org (Postfix, from userid 32767) id 1417F16A417; Thu, 5 Oct 2006 16:03:41 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE87916A403 for ; Thu, 5 Oct 2006 16:03:40 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9584B43D55 for ; Thu, 5 Oct 2006 16:03:40 +0000 (GMT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k95G3eHP026914 for ; Thu, 5 Oct 2006 16:03:40 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k95G3eTV026911 for perforce@freebsd.org; Thu, 5 Oct 2006 16:03:40 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Thu, 5 Oct 2006 16:03:40 GMT Message-Id: <200610051603.k95G3eTV026911@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 107316 for review X-BeenThere: trustedbsd-cvs@FreeBSD.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: TrustedBSD CVS and Perforce commit message list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2006 16:04:59 -0000 http://perforce.freebsd.org/chv.cgi?CH=107316 Change 107316 by rwatson@rwatson_zoo on 2006/10/05 16:03:39 suser(9) unnecessary in a sysctl write. Copy and paste bug from alq. Reviewed by: sam Affected files ... .. //depot/projects/trustedbsd/priv/sys/contrib/dev/ath/freebsd/ah_osdep.c#2 edit Differences ... ==== //depot/projects/trustedbsd/priv/sys/contrib/dev/ath/freebsd/ah_osdep.c#2 (text+ko) ==== @@ -199,16 +199,13 @@ int error; if (enable) { - error = suser(curthread); - if (error == 0) { - error = alq_open(&ath_hal_alq, ath_hal_logfile, - curthread->td_ucred, ALQ_DEFAULT_CMODE, - sizeof (struct athregrec), ath_hal_alq_qsize); - ath_hal_alq_lost = 0; - ath_hal_alq_emitdev = 1; - printf("ath_hal: logging to %s enabled\n", - ath_hal_logfile); - } + error = alq_open(&ath_hal_alq, ath_hal_logfile, + curthread->td_ucred, ALQ_DEFAULT_CMODE, + sizeof (struct athregrec), ath_hal_alq_qsize); + ath_hal_alq_lost = 0; + ath_hal_alq_emitdev = 1; + printf("ath_hal: logging to %s enabled\n", + ath_hal_logfile); } else { if (ath_hal_alq) alq_close(ath_hal_alq);