From owner-freebsd-arch@FreeBSD.ORG Wed Feb 13 15:31:16 2013 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id DCC7FD2F; Wed, 13 Feb 2013 15:31:16 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id B8F009CA; Wed, 13 Feb 2013 15:31:16 +0000 (UTC) Received: from pakbsde14.localnet (unknown [38.105.238.108]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6BD1DB924; Wed, 13 Feb 2013 10:31:15 -0500 (EST) From: John Baldwin To: Adrian Chadd Subject: Re: Proposal: Unify printing the function name in panic messages() Date: Mon, 11 Feb 2013 17:05:08 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; ) References: <51141E33.4080103@gmx.de> <201302111203.19422.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201302111705.08350.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 13 Feb 2013 10:31:15 -0500 (EST) Cc: Kirk McKusick , Christoph Mallon , Andriy Gapon , freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2013 15:31:16 -0000 On Monday, February 11, 2013 4:20:00 pm Adrian Chadd wrote: > Whoa, whoa. > > Are you seriously trying to argue that having a consistent file:line > isn't a really helpful addition to panic messages? > > Yes, you can get it via the crash IP and use of binutils on the kernel > image. But with modules? You have to fire up kgdb, and that requires a > dump _and_ a kgdb that matches the kernel image in question. > > Even if you don't add it to the panic message, having that information > passed into panic() so it can print out a file:line would be great. He isn't adding that, he's adding __func__, and it isn't a fool proof replacement. -- John Baldwin