From owner-freebsd-current@freebsd.org Mon Sep 11 20:04:42 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7108CE214D4 for ; Mon, 11 Sep 2017 20:04:42 +0000 (UTC) (envelope-from tsoome@me.com) Received: from st13p35im-asmtp002.me.com (st13p35im-asmtp002.me.com [17.164.199.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46EB170674 for ; Mon, 11 Sep 2017 20:04:42 +0000 (UTC) (envelope-from tsoome@me.com) Received: from process-dkim-sign-daemon.st13p35im-asmtp002.me.com by st13p35im-asmtp002.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) id <0OW400A00PO76S00@st13p35im-asmtp002.me.com> for freebsd-current@freebsd.org; Mon, 11 Sep 2017 19:04:35 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=04042017; t=1505156675; bh=HYdCPGC6m/1LIf03uhkTgJ9H1EgCPw8r/JdlIgHlr4A=; h=From:Message-id:Content-type:MIME-version:Subject:Date:To; b=t3bwHiBCWrQ0dg4LkI0qDfcpiZukFzWLztHDCaYY/gB87o5uOtuE8jNunNQ3r1T+s 5G87CaFBOtUfawW1F0mWck4qEuCPLjlHdc9bHcir6uEV7rvG9a7tEuQrFld1TB94kZ hJF+AvhRkbf0JYLtOBejAy/HFj+m5vipZT7rNC0E1NMLUUKNIoh+U5+A8U4cJmpBrH 9PkrPreXOq5GlaBZICZjwwas6WQbYxT++7iZaY9i0yhcrQQw1yLyi+ZJ1l0gzPiSMg viA694visheOjz99DxOzPwwOpZbSViqw7nuBZ0TShmUrhM8chX30KT/lKZWk6cgM6S Xr58xmMcT6TgQ== Received: from icloud.com ([127.0.0.1]) by st13p35im-asmtp002.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) with ESMTPSA id <0OW40026UQBJSX10@st13p35im-asmtp002.me.com>; Mon, 11 Sep 2017 19:04:34 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-11_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=12 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709110283 From: Toomas Soome Message-id: <46F10971-5A94-43EF-B4BE-C94CF7D59920@me.com> MIME-version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Buildworld failure in sys/boot/efi/loader/main.c if WITHOUT_ZFS is defined Date: Mon, 11 Sep 2017 22:04:31 +0300 In-reply-to: <3086243.YZ0vIPs7gg@asus.theweb.org.ua> Cc: "freebsd-current@freebsd.org" To: "Oleg V. Nauman" References: <3086243.YZ0vIPs7gg@asus.theweb.org.ua> X-Mailer: Apple Mail (2.3273) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 20:04:42 -0000 Got it fixed in: r323428 | tsoome | 2017-09-11 10:38:53 +0300 (E, 11 sept 2017) | 7 lines r323389 breaks the kernel build when WITHOUT_ZFS is defined in src.conf Need to add #ifdef EFI_ZFS_BOOT guard into efi/loader/main.c PR: 222215 Reported by: Sylvain Garrigues sorry about it, toomas > On 11. sept 2017, at 21:40, Oleg V. Nauman wrote: > > ===> sys/boot/efi/loader (all) > cc -target x86_64-unknown-freebsd12.0 -- > sysroot=/usr/obj/usr/src/tmp -B/usr/obj/usr/src/tmp/usr/bin -O2 > -pipe -march=nehalem - > I/usr/src/sys/boot/efi/loader/../../../../lib/libstand -fPIC - > DTERM_EMU -I/usr/src/sys/boot/efi/loader - > I/usr/src/sys/boot/efi/loader/arch/amd64 - > I/usr/src/sys/boot/efi/loader/../include - > I/usr/src/sys/boot/efi/loader/../include/amd64 - > I/usr/src/sys/boot/efi/loader/../../../contrib/dev/acpica/include > -I/usr/src/sys/boot/efi/loader/../../.. - > I/usr/src/sys/boot/efi/loader/../../i386/libi386 -DNO_PCI -DEFI > -DSMBIOS_SERIAL_NUMBERS -DBOOT_FORTH - > I/usr/src/sys/boot/efi/loader/../../ficl - > I/usr/src/sys/boot/efi/loader/../../ficl/amd64 - > DLOADER_DISK_SUPPORT -DLOADER_GPT_SUPPORT -DLOADER_MBR_SUPPORT - > DLOADER_GELI_SUPPORT -fPIC -I/usr/src/sys/boot/ficl - > I/usr/src/sys/boot/ficl/amd64 - > I/usr/src/sys/boot/ficl/../common - > I/usr/src/sys/boot/efi/loader/../../common -ffreestanding - > Wformat -mno-mmx -mno-sse -mno-avx -msoft-float -fshort-wchar - > mno-red-zone -mno-aes -g -MD -MF.depend.main.o -MTmain.o - > std=gnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k -W - > Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes - > Wpointer-arith -Wno-uninitialized -Wno-pointer-sign -Wno-empty- > body -Wno-string-plus-int -Wno-unused-const-variable -Wno- > tautological-compare -Wno-unused-value -Wno-parentheses-equality > -Wno-unused-function -Wno-enum-conversion -Wno-unused-local- > typedef -Wno-address-of-packed-member -Wno-format -Qunused- > arguments -c /usr/src/sys/boot/efi/loader/main.c -o main.o > /usr/src/sys/boot/efi/loader/main.c:883:8: error: implicit > declaration of function > 'efizfs_get_handle_by_guid' is invalid in C99 [-Werror,- > Wimplicit-function-declaration] > efizfs_get_handle_by_guid(z_dev- >> pool_guid); > ^ > /usr/src/sys/boot/efi/loader/main.c:883:8: error: this function > declaration is not a prototype > [-Werror,-Wstrict-prototypes] > /usr/src/sys/boot/efi/loader/main.c:883:39: error: incomplete > definition of type 'struct zfs_devdesc' > efizfs_get_handle_by_guid(z_dev- >> pool_guid); > ~~~~~^ > /usr/src/sys/boot/efi/loader/main.c:875:10: note: forward > declaration of 'struct zfs_devdesc' > struct zfs_devdesc *z_dev; > ^ > 3 errors generated. > *** Error code 1 > > Stop. > make[6]: stopped in /usr/src/sys/boot/efi/loader > *** Error code 1 > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"