From nobody Wed Feb 25 23:10:35 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fLr0w4Zdjz6SXqg for ; Wed, 25 Feb 2026 23:10:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fLr0w3vhMz3VVk for ; Wed, 25 Feb 2026 23:10:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772061040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IKnY9vJEbJ3DKVGeSykMPMWSqiH4k8INfVuds1ADneg=; b=CwRgvL49u7qna1GLk9bhH2aauBnqFDKFX0PObG68+eCG6w59Xo/QegMl8dz4+NTtuU+o8L /rmAY9fHsLLau8Q95Aa2TpFO9lXkXC72cQesg0HEldOSHiMd/TkczVIgpBjlvyGOsxn5BV ec+1mgh2sVb6QfGyROKnEGB9wrSDgx8Rq4jp71vIbgpr29zNoYTR5pk5SLtQNFH4flD/bx f3H8UDgDNe8pnmA9S+X13ImndfAw5QJupsKulLgTQUm+3suevg0rb3NtEn0pu6fevDFdXd MvZy5cjXIgsQO/ya0qxsYqK5NDn7UXrvGLbTO0gV+dPRFqeaO+cN5O2CJZ/Y1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772061040; a=rsa-sha256; cv=none; b=OL5hwp351H9gNeaatRUh14vEkcVPRWBsIMKzgqIz7K2JNBWVn8srf7snokZ7vPsNKtIzX8 cFyncURblr3drny7MZkp+JNcwaZepW0m4Iw4xodaeMFT6rv4HzNo/v9CyyoTy4bFJ5KhpC ikEYlUz0dl9xK3pNBZVG++cJz82THXAkGH5CFIIy0HGIQ09lsUHxR/w9MztS3mYSnQXsaz HTMDgQAu1f3OW/DTcUIM/NUIn3za7iSenRriXgOEc95l3h6zZYkbxc8ZQLioBs0+R6DMq7 9i2BsZwGzI1UhePlYl5hcrDIMh4PDT+wenS8uZlPsVs6Ws3gZ6CDhGDXiLKngA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772061040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IKnY9vJEbJ3DKVGeSykMPMWSqiH4k8INfVuds1ADneg=; b=U6ixKwe2vzQqVQJbAFuIBGwLyV4iVXPoreaDX4adP4ykebHwp6YWbFxTOkC5kVevBWwQxF +eR/hdGjaSOYZvxt++9z2u4x8ek3Qjl+92hLwzfjKXEg8THy1kYDaadSdYN/X/T9hskdha Yi1j7MB3OOWlkdREis7FpEXabjETPZl6Rr388z44y7fomMAXU3ipo3gGWETu52VjQqdM1n poJw4ZQeFMCAM797CIOAe2RRgky5Rb6lo3RVRQAHY6hXl0xqidR7ro4Jfj4uFU0mvmV7lY MlLuWugSB3JODLHzI66mptPLXTaYWJDApUFkShLNnmwQE5aCgcE7u/jc+CYTkA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fLr0w3J1qz1LBw for ; Wed, 25 Feb 2026 23:10:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3b3d9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 25 Feb 2026 23:10:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: David Bright Subject: git: 42ab99095b7d - main - procstat: CID 1593951: Resource leak List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dab X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 42ab99095b7dc2243629574e1c627cf5e6a9070c Auto-Submitted: auto-generated Date: Wed, 25 Feb 2026 23:10:35 +0000 Message-Id: <699f816b.3b3d9.505fb456@gitrepo.freebsd.org> The branch main has been updated by dab: URL: https://cgit.FreeBSD.org/src/commit/?id=42ab99095b7dc2243629574e1c627cf5e6a9070c commit 42ab99095b7dc2243629574e1c627cf5e6a9070c Author: David Bright AuthorDate: 2026-02-21 22:47:00 +0000 Commit: David Bright CommitDate: 2026-02-22 21:29:25 +0000 procstat: CID 1593951: Resource leak Summary: A trivial resource leak fix; free the allocated memory before return. Test Plan: Code inspection, run command. I built a simple program that waits for a signal on a kqueue, then ran that. The standard procstat displays: ``` fbsd-dev% Waiting for SIGTERM... procstat -a kqueue PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS 84352 3 SIGNAL 15 C - 0 0x0 - ``` The revised procstat displays: ``` fbsd-dev% sudo LD_LIBRARY_PATH=/usr/obj/usr/home/dab/git/freebsd/src/arm64.aarch64/lib/libutil /usr/obj/usr/home/dab/git/freebsd/src/arm64.aarch64/usr.bin/procstat/procstat -a kqueue PID KQFD FILTER IDENT FLAGS FFLAGS DATA UDATA STATUS 84352 3 SIGNAL 15 C - 0 0x0 - fbsd-dev% ``` As expected, the two displays are identical. This doesn't prove that the leak is gone, but it does prove that the revised command still operates correctly. I think it can clearly be seen from inspection of the change that the leak has been remedied. Reviewed-bys: vangyzen Differential Revision: https://reviews.freebsd.org/D55422 --- usr.bin/procstat/procstat_kqueue.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/usr.bin/procstat/procstat_kqueue.c b/usr.bin/procstat/procstat_kqueue.c index ce9d2cb42fe2..b4d396e12d3a 100644 --- a/usr.bin/procstat/procstat_kqueue.c +++ b/usr.bin/procstat/procstat_kqueue.c @@ -135,8 +135,10 @@ procstat_kqueue_flags(const struct pk_elem *names, unsigned flags, bool commas) } } - if (strlen(res) == 0) - return (strdup("-")); + if (strlen(res) == 0) { + free(res); + res = strdup("-"); + } return (res); }