From owner-freebsd-bugs@FreeBSD.ORG  Thu Jan 27 03:00:23 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 40F7010656E0
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 27 Jan 2011 03:00:23 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 16A868FC4F
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 27 Jan 2011 03:00:23 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0R30Mw5047053
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 27 Jan 2011 03:00:22 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0R30M2d047033;
	Thu, 27 Jan 2011 03:00:22 GMT (envelope-from gnats)
Date: Thu, 27 Jan 2011 03:00:22 GMT
Message-Id: <201101270300.p0R30M2d047033@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/154220: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Jan 2011 03:00:23 -0000

The following reply was made to PR kern/154220; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/154220: commit references a PR
Date: Thu, 27 Jan 2011 02:56:15 +0000 (UTC)

 Author: adrian
 Date: Thu Jan 27 02:56:03 2011
 New Revision: 217921
 URL: http://svn.freebsd.org/changeset/base/217921
 
 Log:
   Writing to the analog registers on the AR9220 (Merlin PCI) seems to require a delay.
   
   This, along with an initval change which will appear in a subsequent commit,
   fixes bus panics that I have been seing with the AR9220 on a Routerstation Pro
   (AR7161 MIPS board.)
   
   Obtained from: Linux ath9k
   PR: kern/154220
 
 Modified:
   head/sys/dev/ath/ath_hal/ah.c
 
 Modified: head/sys/dev/ath/ath_hal/ah.c
 ==============================================================================
 --- head/sys/dev/ath/ath_hal/ah.c	Thu Jan 27 02:27:17 2011	(r217920)
 +++ head/sys/dev/ath/ath_hal/ah.c	Thu Jan 27 02:56:03 2011	(r217921)
 @@ -858,6 +858,11 @@ ath_hal_ini_write(struct ath_hal *ah, co
  	for (r = 0; r < ia->rows; r++) {
  		OS_REG_WRITE(ah, HAL_INI_VAL(ia, r, 0),
  		    HAL_INI_VAL(ia, r, col));
 +
 +		/* Analog shift register delay seems needed for Merlin - PR kern/154220 */
 +		if (HAL_INI_VAL(ia, r, 0) >= 0x7800 && HAL_INI_VAL(ia, r, 0) < 0x78a0)
 +			OS_DELAY(100);
 +
  		DMA_YIELD(regWr);
  	}
  	return regWr;
 @@ -881,6 +886,10 @@ ath_hal_ini_bank_write(struct ath_hal *a
  
  	for (r = 0; r < ia->rows; r++) {
  		OS_REG_WRITE(ah, HAL_INI_VAL(ia, r, 0), data[r]);
 +
 +		/* Analog shift register delay seems needed for Merlin - PR kern/154220 */
 +		if (HAL_INI_VAL(ia, r, 0) >= 0x7800 && HAL_INI_VAL(ia, r, 0) < 0x78a0)
 +			OS_DELAY(100);
  		DMA_YIELD(regWr);
  	}
  	return regWr;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"