From owner-svn-ports-head@freebsd.org Tue May 22 14:08:49 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0BFBEF734A for ; Tue, 22 May 2018 14:08:48 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74BE676A3F for ; Tue, 22 May 2018 14:08:48 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-io0-x22e.google.com with SMTP id e20-v6so18607843iof.4 for ; Tue, 22 May 2018 07:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Q7w0p1q/0VxeC6guuw5p5kl7ikHTiLpTgsqi9KWUEPg=; b=Vj5Y1nNExnWTNByl/JDBXcWs1+NvUVixVuxnKOg7eC4DYxNTaA6J5NNZwBTdDps6jE GFv9oPiN0FBY+krN/6/njdqij2FaNutIHwvJ6zdsQtbOc+yUVVBi50om0fxg9WjN2wcI kh8Y3qAqsl3M72tvpbyL/BqsHMykZxxSl/m55KOMD2OoERQHtSDIM7VHSsd0OpO2QoxK sqQ0wlo2lUqhmiQD/OGViydeVMHNpcCnhto0Sg4TlpQ/Zzzkpukof37LTLFqmb6eg2UU qUDq3dkYO6lEMYG9Ye4a9WSbP1TcNVJWEjlB3VWWJkG5mxQxLGpojsae/xXcztpNtjQ7 DR8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Q7w0p1q/0VxeC6guuw5p5kl7ikHTiLpTgsqi9KWUEPg=; b=JC9p/WIXCEowIOLejS55uo9wM6aX/JbmJRnJRilcahvFGY/0cCP6CjjLfERbdToory wvPUe5ybOpz5Dl5zX+Q7M7ezcUpUf1tlVk8FV3oCsW8q9X4xxpmsXGfKIt4ov/oqv8NM Kq+m86hjlV3z/wabLJffBUZRQlB9nknV8uG1cKnteq7wyHzVrg90fyJPSBShGfKPMnVE 4gMIW3wTsRXJiETIjG8baQYE/GAPXJTDRvwWQITzUnKO5BalClemSDEAD429g44aK0nQ 6/QNKVd3hP42WKtQeP4N6peiQktwBsG6fJ6zPjEpNWY0P1mTQi8my7P2yl1kgCKThEfn HD9g== X-Gm-Message-State: ALKqPwfPgYUGP3Tz38NzOKhj1L34VVGLKNX/a/AxKXst+m4NBhUl/nEc VXHOw3qICHA4eVrTsCtblDG20zwmudhiF6X7gUeXvg== X-Google-Smtp-Source: AB8JxZo717n697p1Z31JgVbGNM2Xy5vjZBHf2bZhrc2IK2C7NN1v3jQPzw9YEn9uAyU9yqCxkqOs2EZOLLZRQV4bdlY= X-Received: by 2002:a6b:88e3:: with SMTP id s96-v6mr25833084ioi.45.1526998127702; Tue, 22 May 2018 07:08:47 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 2002:a02:910a:0:0:0:0:0 with HTTP; Tue, 22 May 2018 07:08:07 -0700 (PDT) In-Reply-To: <20180522135231.bdudnyrreswcumwe@ogg.in.absolight.net> References: <201805121859.w4CIx8jx035047@repo.freebsd.org> <20180515140351.oyfapiqygprxomvq@ogg.in.absolight.net> <333774c1-c120-2582-9a60-1b1c784cdd5b@freebsd.org> <20180522135231.bdudnyrreswcumwe@ogg.in.absolight.net> From: Sunpoet Po-Chuan Hsieh Date: Tue, 22 May 2018 22:08:07 +0800 X-Google-Sender-Auth: bIagxQ5MnMWNIVuJ91rnBlj3hy4 Message-ID: Subject: Re: svn commit: r469754 - in head/ports-mgmt/portlint: . src To: Mathieu Arnold Cc: Joe Marcus Clarke , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 14:08:49 -0000 On Tue, May 22, 2018 at 9:52 PM, Mathieu Arnold wrote: > On Mon, May 21, 2018 at 11:57:36AM -0400, Joe Marcus Clarke wrote: > > On 5/15/18 10:03, Mathieu Arnold wrote: > > > On Sat, May 12, 2018 at 06:59:08PM +0000, Joe Marcus Clarke wrote: > > >> if ($m{'fla'} ne '${PY_FLAVOR}') { > > >> - &perror("FATAL", $file, > -1, "directory for dependency ". > > >> - "$m{'dep'} must be > $m{'dir'}:\@\${PY_FLAVOR}"); > > >> + &perror("WARN", $file, -1, > "you may want directory for ". > > >> + "dependency > $m{'dep'} to be $m{'dir'}:\@\${PY_FLAVOR}"); > > >> } > > >> } else { > > >> if ($m{'fla'} ne '${FLAVOR}') { > > >> - &perror("FATAL", $file, > -1, "directory for dependency ". > > >> - "$m{'dep'} must be > $m{'dir'}:\@\${FLAVOR}"); > > >> + &perror("WARN", $file, -1, > "you may want directory for ". > > >> + "dependency > $m{'dep'} to be $m{'dir'}:\@\${FLAVOR}"); > > > > > > Could you please only tell people to use PY_FLAVOR? Using FLAVOR > > > directly dates back from when I was implementing the Python flavors and > > > is a bad idea. > > > > > > > Does this look right: > > Mmmm, I think it does, yes. Though the check is probably wrong, it > should probably not be looking for /^py-/ in the second field, but for > ${PYTHON_PKGNAMEPREFIX} in the first field. > Please also include the check of ${PYTHON_PKGNAMESUFFIX}. > > diff -u -r1.463 portlint.pl > > --- portlint.pl 12 May 2018 22:12:18 -0000 1.463 > > +++ portlint.pl 21 May 2018 15:57:25 -0000 > > @@ -1149,18 +1149,9 @@ > > # check Python flavor > > my $bdir = basename($m{'dir'}); > > if ($bdir =~ /^py-/) { > > - if (!defined($makevar{USE_PYTHON}) || > > - $makevar{USE_PYTHON} eq > 'noflavors' || > > - $makevar{USE_PYTHON} eq '') { > > - if ($m{'fla'} ne '${PY_FLAVOR}') { > > - &perror("WARN", $file, -1, > "you may want directory for ". > > - "dependency > $m{'dep'} to be $m{'dir'}:\@\${PY_FLAVOR}"); > > - } > > - } else { > > - if ($m{'fla'} ne '${FLAVOR}') { > > - &perror("WARN", $file, -1, > "you may want directory for ". > > - "dependency > $m{'dep'} to be $m{'dir'}:\@\${FLAVOR}"); > > - } > > + if ($m{'fla'} ne '${PY_FLAVOR}') { > > + &perror("WARN", $file, -1, "you > may want directory for ". > > + "dependency $m{'dep'} to > be $m{'dir'}:\@\${PY_FLAVOR}"); > > } > > } > > > > > > -- > Mathieu Arnold >