From owner-svn-src-all@FreeBSD.ORG Mon Mar 16 21:14:19 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9AA9EC61; Mon, 16 Mar 2015 21:14:19 +0000 (UTC) Received: from mail-ie0-x234.google.com (mail-ie0-x234.google.com [IPv6:2607:f8b0:4001:c03::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B4748A3; Mon, 16 Mar 2015 21:14:19 +0000 (UTC) Received: by iecvj10 with SMTP id vj10so178390714iec.0; Mon, 16 Mar 2015 14:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=zMvZsVwDj2NUIhtV5yosv/QtV80UnHQx9vcZcps9ETI=; b=xDBo/Ub6PHqAEVw+Ec641SK7iD9pRWLwOMo+WQWPi48LKrpfQxnBY3jqmjjidKEION tjgRiBCr6XRPm6qZ3HGzT+6jv+XipG7YmEh32TKmO/+HK3P7MSBatzMC/HjumV89XanW HRGBbrgb8L2pqe8R6B92q5UEbn18+ZngAilNSZqWvXGx00rIGedwDSUg3X6E4GitXGgs 8YjNEO0L8nrMVIuIicC6UCxtEm9Hi6pNP99gSvf8swMZGrgKqBJAxXUqfa1+ozd3qgjK QYKjqnCjMECIM0iA612mO2DGRgoM6DM0BVqMbkicgtfDxWin4nWfzHKBL2BBhHnQAF2D Yltg== X-Received: by 10.51.17.7 with SMTP id ga7mr96332746igd.42.1426540458804; Mon, 16 Mar 2015 14:14:18 -0700 (PDT) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.98.234 with HTTP; Mon, 16 Mar 2015 14:13:48 -0700 (PDT) In-Reply-To: <201503162013.t2GKDQFr009617@svn.freebsd.org> References: <201503162013.t2GKDQFr009617@svn.freebsd.org> From: Bryan Venteicher Date: Mon, 16 Mar 2015 16:13:48 -0500 X-Google-Sender-Auth: gAz-q72Mzb2zF9QJw9XZ6doKx88 Message-ID: Subject: Re: svn commit: r280154 - head/usr.sbin/bhyve To: Alexander Motin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 21:14:19 -0000 On Mon, Mar 16, 2015 at 3:13 PM, Alexander Motin wrote: > Author: mav > Date: Mon Mar 16 20:13:25 2015 > New Revision: 280154 > URL: https://svnweb.freebsd.org/changeset/base/280154 > > Log: > Report that we may have write cache, and that we do support FLUSH. > > FreeBSD guest driver does not use that legacy flag, but Linux seems does. > > The guest driver calls it by a prior name: VIRTIO_BLK_F_WCE. The write cache stuff went through several iterations, and goes away in VirtIO 1.0 specification. > MFC after: 2 weeks > > Modified: > head/usr.sbin/bhyve/pci_virtio_block.c > > Modified: head/usr.sbin/bhyve/pci_virtio_block.c > > ============================================================================== > --- head/usr.sbin/bhyve/pci_virtio_block.c Mon Mar 16 20:00:09 2015 > (r280153) > +++ head/usr.sbin/bhyve/pci_virtio_block.c Mon Mar 16 20:13:25 2015 > (r280154) > @@ -64,6 +64,7 @@ __FBSDID("$FreeBSD$"); > /* Capability bits */ > #define VTBLK_F_SEG_MAX (1 << 2) /* Maximum request > segments */ > #define VTBLK_F_BLK_SIZE (1 << 6) /* cfg block size > valid */ > +#define VTBLK_F_FLUSH (1 << 9) /* Cache flush > support */ > #define VTBLK_F_TOPOLOGY (1 << 10) /* Optimal I/O > alignment */ > > /* > @@ -72,6 +73,7 @@ __FBSDID("$FreeBSD$"); > #define VTBLK_S_HOSTCAPS \ > ( VTBLK_F_SEG_MAX | \ > VTBLK_F_BLK_SIZE | \ > + VTBLK_F_FLUSH | \ > VTBLK_F_TOPOLOGY | \ > VIRTIO_RING_F_INDIRECT_DESC ) /* indirect descriptors */ > > >