Date: Tue, 15 Mar 2016 00:33:27 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207657] games/fairymax: Update to 5.0b Message-ID: <bug-207657-13-cCnbvxKtYK@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-207657-13@https.bugs.freebsd.org/bugzilla/> References: <bug-207657-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207657 Kalten <kalten@gmx.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167651|0 |1 is obsolete| | Attachment #167652|0 |1 is obsolete| | Attachment #167655|0 |1 is obsolete| | --- Comment #5 from Kalten <kalten@gmx.at> --- Created attachment 168193 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D168193&action= =3Dedit games/fairymax: update to 5.0b patch [3] (In reply to Raphael Kubo da Costa from comment #4) > - share/games/plugins looks like a very generic directory for fairymax to > use. How about setting |plugindir| to ${DATADIR}/plugins in MAKE_ARGS. In principal it has to be as it is: Ports like games/xboard expect to find the files there for all =E2=80=9Cchess=E2=80=9D engines. If I do recall my = research when I did create games/fairymax right, there are more games related ports using exactly this mechanism. (But change to it in [v3] due to your wish to use no do-install target) (=C2=BBgames/fairymax: update to 5.0b patch [3]=C2=AB shall be denoted as [= v3] from now on) > - INI_Q already seems to be set to ${DATADIR}/qmax.ini since you set > fairydir to ${DATADIR}, so I guess you don't need to explicitly set it. It seems, that you are right=E2=80=94thank you! I have changed MAKE_ARGS accordingly. [v3] > - "-O2" doesn't really justify having an OPTIMIZED_CFLAGS option. It's > passed by default by the ports tree along with "-pipe -fstack-protector > -fno-strict-aliasing". Very well. I have deleted this option. [v3] > - The fairymax.pod sed call doesn't seem to be replacing anything in this > version. Interesting: How did I come up with that? Thanks again: I have deleted this in [v3]. > - fairymax's Makefile already has an install target, do you really need > to have a custom do-install target yourself? Well: we have to change some things for that, but=E2=80=94so be it [v3] I do understand your point of view (and I was able to shorten it a bit). (I should beg H.G.Muller to change the code of his Makefile to allow us to overwrite the destinations from outside (i.e. to be able to get rid of the new =C2=BB=3D=C2=AB to =C2=BB?=3D=C2=AB in our post-patch target) I have deleted the two ln(1) statements in the post-install target (and this as a whole with them) as the manual page of xboard does neither speak about shamax nor about maxqi. The output of =C2=BBportlint -AC=C2=AB with comments:[v3] ------------------------------------------------------------------------ > WARN: Makefile: [0]: possible direct use of command "cp" found. > use ${CP} instead. [three times] That is in our post-patch target in a sed expression on its left side and therefor OK. > WARN: Makefile: for new port, make $FreeBSD$ tag in comment section > empty, to make SVN happy. It is not a new port. > WARN: Makefile: Consider defining LICENSE. Well: difficult: see his file =C2=BBcopyright=C2=AB. I do not know what to = enter in the Makefile. (same as at times of bug #193544) > 0 fatal errors and 5 warnings found. ------------------------------------------------------------------------ Regards, Kalten --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207657-13-cCnbvxKtYK>