From owner-freebsd-current@FreeBSD.ORG  Fri Jun  1 19:20:31 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4F0F316A468;
	Fri,  1 Jun 2007 19:20:31 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id ED77A13C480;
	Fri,  1 Jun 2007 19:20:30 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l51JJkeN086424;
	Fri, 1 Jun 2007 13:19:46 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Fri, 01 Jun 2007 13:19:46 -0600 (MDT)
Message-Id: <20070601.131946.71174943.imp@bsdimp.com>
To: mike@Reifenberger.com
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <20070601125901.W92469@fw.reifenberger.com>
References: <20070601105521.D77697@fledge.watson.org>
	<20070601125901.W92469@fw.reifenberger.com>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Fri, 01 Jun 2007 13:19:46 -0600 (MDT)
Cc: rwatson@freebsd.org, current@freebsd.org
Subject: Re: NET_NEEDS_GIANT removal
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jun 2007 19:20:31 -0000

> > i4b		- ISDN implementation
> ...
> 
> Before deleting we should replace i4b with the one from hps.
> http://www.selasky.org/hans_petter/isdn4bsd/index.html
> It was said to be GIANT free last time I asked.

Who has reviewed this code?  Last time I checked, it had all kinds of
Byzantine construts that made it extremely difficult to penetrate.
There were very few comments and it implemented state machines as
computed gotos :-(.  The cure would be worse than the disease.

Warner