Date: Wed, 10 May 2023 19:25:07 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269616] [NEW PORT] astro/osmium-tool: Command line tool for working with OpenStreetMap data based on the Osmium library Message-ID: <bug-269616-7788-HlRzMVwP8c@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-269616-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-269616-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269616 Robert Clausecker <fuz@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org Status|New |Open --- Comment #3 from Robert Clausecker <fuz@FreeBSD.org> --- Thank you for your submission. Please ensure to set maintainer-approval to= + on newly submitted ports so they get processed quicker. Here are some thin= gs I noticed: - your pkg-plist lists all the man pages, but these get only built when the MANPAGES option is on. Either make the pkg-plist entries for man pages conditional on whether the option is set or not, or make installing man pages unconditional. - please fix the indentation of the port Makefile. You can use portfmt for this. - it might be useful to enable the LZ4 option by default. liblz4 is a rea= lly small library, so it doesn't hurt to have it. - your MANPAGES and LZ4 options do not set anything in the build scripts, = so they will not work correctly when e.g. liblz4 is installed but not selec= ted as an option. Please check if you can wire the options through to the b= uild system so LZ4 support is indeed only built if the option is set. Port looks good otherwise! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-269616-7788-HlRzMVwP8c>