From nobody Sat Jan 7 11:48:53 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Npz4j6MYFz2p95H for ; Sat, 7 Jan 2023 11:48:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Npz4j2t1hz46JN for ; Sat, 7 Jan 2023 11:48:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673092133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PARPp/8bTcUJUtrp3dfjgmKX4HVQF23LU650qNba00E=; b=IC0ShyAJ9hfmlp5JxZHnHCkVKKSe/CACg7rJJFi741/zMnytHsZC4OtCAnvAdvyvOYXqqP MwxEb7mOpP3slhdSC///c1+oZiOHjCgTx8AETJjt/nBTEBJVE46Htkv0O/32ceJiFK/g0U 0WJm18Xec8TP3YUp06dXtu2mRI7+6UKwAyymhsZV1nlRecy3DuZ3g00zDAiv+QAu8uzHe1 fY1YlsVIwLMISrBHSq0CEiIYSPVTFDd9d7oHA3zYzBSCiBcv4tdKFOGXGnhJTWUyvxwQiP LUrFW+zCKP0F/KxPIQvoLWRrNZLgLmwgTT99efGnZlIDOibfaq7defQm7SXayA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1673092133; a=rsa-sha256; cv=none; b=C/pNvKqKEO06l03nCl8feI+MpbNiNAXqfUCyyNSeSodXonu1+71RzUuJNyigyW1kkfxuWF Nzs8gfxlZqwZhThmRNTH+qbeT6SD9nKqapJ5GsmlqLY2tMagfLRK8Niqjf9ZGnrU9N6C3H WAqSGqmGmOWLCR85V0wp/mIb9zpEUrMovp1ibGbPb2G6awfn9U+dAyXKF9glc0ZpKCoc4H I2X9BXOj81vO57ZiN8+aJhkBRsHTVmamK2kQKVSszm1Yim39A2iZXQr4T8DbWHHYsoS2qf 9ABHOcHYTs6fFWVKDgdeamQmxOvpWZHkk0iRWKXHJ1OaEqlDLTFaB4Sl8ME3eg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Npz4j1ynrz17bm for ; Sat, 7 Jan 2023 11:48:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 307Bmro6033498 for ; Sat, 7 Jan 2023 11:48:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 307BmrnN033496 for ports-bugs@FreeBSD.org; Sat, 7 Jan 2023 11:48:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 268776] audio/d11amp 0.61: New port 3 Date: Sat, 07 Jan 2023 11:48:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: zirias@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: zirias@freebsd.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: cc assigned_to bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268776 Felix Palmen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zirias@freebsd.org Assignee|ports-bugs@FreeBSD.org |zirias@freebsd.org Status|New |Open --- Comment #1 from Felix Palmen --- (In reply to Thomas Dettbarn from comment #0) Thanks, this looks *almost* perfect. A style nitpick: PLIST_FILES belongs *after* the "make block" (where you de= fine your TEST stuff). And then, as your upstream *does* respect DESTDIR now, the whole do-install: rule should be unnecessary. I will just test that now (will take a while ag= ain as I have to rebuild lots of updated packages ...) A little tip for upstream: you could make it even more flexible using a structure e.g. like this: --- PREFIX?=3D/usr/local BINDIR?=3D$(PREFIX)/bin MANDIR?=3D$(PREFIX)/share/man INSTALLBIN=3D$(DESTDIR)$(BINDIR) ... --- But it's of course fine as it is now for packaging purposes! --=20 You are receiving this mail because: You are the assignee for the bug.=