From owner-svn-src-all@freebsd.org Tue May 7 17:00:10 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 38D09158D507; Tue, 7 May 2019 17:00:10 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D479D6B054; Tue, 7 May 2019 17:00:09 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.15] (c-71-198-162-232.hsd1.ca.comcast.net [71.198.162.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 1A2B31F855; Tue, 7 May 2019 17:00:09 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/10.18.0.190414 Date: Tue, 07 May 2019 10:00:05 -0700 Subject: Re: svn commit: r347228 - head/sys/kern From: Ravi Pokala To: Ed Maste , , , Message-ID: Thread-Topic: svn commit: r347228 - head/sys/kern References: <201905071617.x47GHXB0065438@repo.freebsd.org> In-Reply-To: <201905071617.x47GHXB0065438@repo.freebsd.org> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable X-Rspamd-Queue-Id: D479D6B054 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.92)[-0.918,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 May 2019 17:00:10 -0000 > + # Avoid a literal generated file tag here. > + generated =3D "@" "generated"; > + Why is that needed here, but not in r347224? -Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: on behalf of Ed Maste Date: 2019-05-07, Tuesday at 09:17 To: , , Subject: svn commit: r347228 - head/sys/kern Author: emaste Date: Tue May 7 16:17:33 2019 New Revision: 347228 URL: https://svnweb.freebsd.org/changeset/base/347228 Log: makesyscalls: use @generated tag in generated files =20 Multiple tools use @generated to identify generated files (for example, in a review Phabricator will by default hide diffs in generated files). Use the @generated tag in makesyscalls.sh as we've done for other generated files. =20 Reviewed by: cem MFC after: 1 month Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D20183 Modified: head/sys/kern/makesyscalls.sh Modified: head/sys/kern/makesyscalls.sh =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D --- head/sys/kern/makesyscalls.sh Tue May 7 15:03:26 2019 (r347227) +++ head/sys/kern/makesyscalls.sh Tue May 7 16:17:33 2019 (r347228) @@ -142,18 +142,21 @@ sed -e ' capenabled_string =3D \"$capenabled\" "' =20 + # Avoid a literal generated file tag here. + generated =3D "@" "generated"; + split(capenabled_string, capenabled, ","); =20 printf "\n/* The casts are bogus but will do for now. */\n" > sysent printf "struct sysent %s[] =3D {\n",switchname > sysent =20 printf "/*\n * System call switch table.\n *\n" > syssw - printf " * DO NOT EDIT-- this file is automatically generated.\n" > syss= w + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = syssw printf " * $%s$\n", "FreeBSD" > syssw printf " */\n\n" > syssw =20 printf "/*\n * System call prototypes.\n *\n" > sysarg - printf " * DO NOT EDIT-- this file is automatically generated.\n" > sysa= rg + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = sysarg printf " * $%s$\n", "FreeBSD" > sysarg printf " */\n\n" > sysarg printf "#ifndef %s\n", sysproto_h > sysarg @@ -187,23 +190,23 @@ sed -e ' printf "\n#ifdef %s\n\n", compat11 > syscompat11 =20 printf "/*\n * System call names.\n *\n" > sysnames - printf " * DO NOT EDIT-- this file is automatically generated.\n" > sysn= ames + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = sysnames printf " * $%s$\n", "FreeBSD" > sysnames printf " */\n\n" > sysnames printf "const char *%s[] =3D {\n", namesname > sysnames =20 printf "/*\n * System call numbers.\n *\n" > syshdr - printf " * DO NOT EDIT-- this file is automatically generated.\n" > sysh= dr + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = syshdr printf " * $%s$\n", "FreeBSD" > syshdr printf " */\n\n" > syshdr =20 printf "# FreeBSD system call object files.\n" > sysmk - printf "# DO NOT EDIT-- this file is automatically generated.\n" > sysmk + printf "# DO NOT EDIT-- this file is automatically " generated ".\n" > s= ysmk printf "# $%s$\n", "FreeBSD" > sysmk printf "MIASM =3D " > sysmk =20 printf "/*\n * System call argument to DTrace register array converstion= .\n *\n" > systrace - printf " * DO NOT EDIT-- this file is automatically generated.\n" > syst= race + printf " * DO NOT EDIT-- this file is automatically " generated ".\n" > = systrace printf " * $%s$\n", "FreeBSD" > systrace printf " * This file is part of the DTrace syscall provider.\n */\n\n" >= systrace printf "static void\nsystrace_args(int sysnum, void *params, uint64_t *u= arg, int *n_args)\n{\n" > systrace