Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Aug 2022 04:22:56 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Jessica Clarke <jrtc27@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>
Subject:   Re: git: 05c9a0158f68 - main - libc: Add strverscmp(3) and versionsort(3)
Message-ID:  <YwbO8Na3k0BpvWmn@kib.kiev.ua>
In-Reply-To: <FFCE6298-AF3B-4B50-B1C1-B4E01F604B30@freebsd.org>
References:  <202208250029.27P0TRwK091769@gitrepo.freebsd.org> <FFCE6298-AF3B-4B50-B1C1-B4E01F604B30@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 25, 2022 at 02:07:12AM +0100, Jessica Clarke wrote:
> On 25 Aug 2022, at 01:29, Konstantin Belousov <kib@FreeBSD.org> wrote:
> > +	const unsigned char *u1 = __DECONST(const unsigned char *, s1);
> > +	const unsigned char *u2 = __DECONST(const unsigned char *, s2);
> 
> Why is __DECONST needed? Casting from const char * to const unsigned
> char * should never warn, surely?

I requested the use of __DECONST there. Nobody knows what would be next
trend in the C language breaking among compiler writers. We guarantee
that __DECONST() is adopted to whatever warnings are added.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YwbO8Na3k0BpvWmn>