From owner-svn-src-head@freebsd.org Thu Aug 11 15:10:22 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD1C2BB5660; Thu, 11 Aug 2016 15:10:22 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E0EE18D1; Thu, 11 Aug 2016 15:10:22 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id D8BB625D389C; Thu, 11 Aug 2016 15:10:18 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id E51E7D1F839; Thu, 11 Aug 2016 15:10:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id G824wzfcjfga; Thu, 11 Aug 2016 15:10:16 +0000 (UTC) Received: from [10.248.105.13] (fresh-tun0-ula.sbone.de [IPv6:fde9:577b:c1a9:4920:2ef0:eeff:fe03:ee34]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id DFA20D1F814; Thu, 11 Aug 2016 15:10:15 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Jean-S??bastien P??dron" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, "Konstantin Belousov" Subject: Re: svn commit: r303890 - in head/sys: contrib/ncsw/user/env contrib/octeon-sdk dev/auxio dev/bktr dev/e1000 dev/ixgb dev/ixgbe dev/ixl dev/netmap dev/pci dev/sound/sbus dev/tpm kern mips/nlm/dev/net m... Date: Thu, 11 Aug 2016 15:10:13 +0000 Message-ID: <18158D1D-52E7-4894-A606-6672E81A1D45@FreeBSD.org> In-Reply-To: <20160810110229.GK83214@kib.kiev.ua> References: <201608091932.u79JW6Y6069448@repo.freebsd.org> <20160810110229.GK83214@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Content-Transfer-Encoding: quoted-printable X-Mailer: MailMate (2.0BETAr6047) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 15:10:23 -0000 On 10 Aug 2016, at 11:02, Konstantin Belousov wrote: > On Tue, Aug 09, 2016 at 07:32:06PM +0000, Jean-S??bastien P??dron = > wrote: >> Author: dumbbell >> Date: Tue Aug 9 19:32:06 2016 >> New Revision: 303890 >> URL: https://svnweb.freebsd.org/changeset/base/303890 >> >> Log: >> Consistently use `device_t` >> >> Several files use the internal name of `struct device` instead of >> `device_t` which is part of the public API. This patch changes all >> `struct device *` to `device_t`. >> >> The remaining occurrences of `struct device` are those referring to = >> the >> Linux or OpenBSD version of the structure, or the code is not built = >> on >> FreeBSD and it's unclear what to do. >> >> Submitted by: Matthew Macy (previous version) >> Approved by: emaste, jhibbits, sbruno >> MFC after: 3 days >> Differential Revision: https://reviews.freebsd.org/D7447 > > On powerpc and powerpc64, at r303902, I got > =3D=3D=3D> usr.sbin/camdd (all) > In file included from = > /scratch/tmp/kib/obj/powerpc.powerpc64/scratch/tmp/kib/src > /tmp/usr/include/machine/bus.h:463, > from /scratch/tmp/kib/src/usr.sbin/camdd/camdd.c:54: > /scratch/tmp/kib/obj/powerpc.powerpc64/scratch/tmp/kib/src/tmp/usr/incl= ude/machi > ne/bus_dma.h:33: error: expected declaration specifiers or '...' = > before 'device_ > t' > --- camdd.o --- > *** [camdd.o] Error code 1 > I waited for another day; now just reverted the change on the header = file in order to get a working universe build again hopefully. In case = this will be MFCed please take appropriate care to not break 11. /bz