From owner-freebsd-current Sat Jan 11 16:51:55 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E9CC37B401; Sat, 11 Jan 2003 16:51:53 -0800 (PST) Received: from smtp.comcast.net (smtp.comcast.net [24.153.64.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F28843F1E; Sat, 11 Jan 2003 16:51:45 -0800 (PST) (envelope-from trish@bsdunix.net) Received: from femme.sapphite.org (pcp02268182pcs.longhl01.md.comcast.net [68.50.99.190]) by mtaout06.icomcast.net (iPlanet Messaging Server 5.2 HotFix 1.07 (built Nov 25 2002)) with ESMTP id <0H8K005Y8T2851@mtaout06.icomcast.net>; Sat, 11 Jan 2003 19:51:45 -0500 (EST) Received: from localhost (trish@localhost [127.0.0.1]) by femme.sapphite.org (8.12.6/8.12.6) with ESMTP id h0C0pgwj036333; Sat, 11 Jan 2003 19:51:43 -0500 (EST envelope-from trish@bsdunix.net) Date: Sat, 11 Jan 2003 19:51:42 -0500 (EST) From: Trish Lynch Subject: Re: Serious issues with kqueue on sockets on CURRENT. In-reply-to: <3E2052FC.B490B429@newsguy.com> X-X-Sender: To: "Daniel C. Sobral" Cc: Peter Wemm , current@FreeBSD.ORG, kbyanc@FreeBSD.ORG Message-id: <20030111194549.V758-100000@femme> MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Content-transfer-encoding: 7BIT Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 11 Jan 2003, Daniel C. Sobral wrote: > Peter, reverting the revisions below *does* fix the problem. Tim has an > alternative patch, though. At any rate, it seems kbyanc's solution was > overly simplistic. But things are broken either way, and I'm not sure > Tim's patch doesn't result in the kind of situation rev 1.134 tried to > fix, nor if his patch actually gets all cases of the bug that results > from 1.134. > > At any rate, I think that not receiving any event (after 1.134) is worse > than receiving and event claim to have more bytes than are actually > available (pre 1.134). It's not just Juli who have this problem. > AilleCat, for instance, once she heard on irc that kq had a problem, > tracked the problem *she* was having to the same place. > Yes, this is correct, some events weren't being triggered and now, with reverting back (with some of the current changes like the aesthetic change to soo_kqfilter instead of sokqfilter,) now our application that relies upon kqueue for scheduling runs about twice as fast.... Maxim gave me a patch that accomplishes exactly what I did by hand... but it also leaves it in a state that it was before 1.134 where there were some problems that were supposed to be fixed in 1.134 and after... however IMO its *less* broken :) Anyway, since my understanding of this is much less than anyone else I'm inclined to go with whatever solution actually makes the events trigger for us :) I'm not a kernel programmer, nor will I ever be, I just know that reverting uipc_socket.c did solve some major problems I was having :) -Trish -- Trish Lynch trish@bsdunix.net Ecartis Core Team trish@listmistress.org EFNet IRC Operator @ efnet.demon.co.uk AilleCat@EFNet Key fingerprint = C44E 8E63 6E3C 18BD 608F E004 9DC7 C2E9 0E24 DFBD To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message