From nobody Fri May 30 17:26:11 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b89BY3rwZz5xvbL; Fri, 30 May 2025 17:26:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b89BX4H7Mz3CXK; Fri, 30 May 2025 17:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748625972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JxBkd/ic5we+MeRJA72l3Y83kkiyv1bxZI/U3KJ/ErU=; b=Vwyyy/ab3Iq6nbhMRhjH8hsxuyvU5oc1y/xAP2OfHLDOnZEVl4AwVU0QR/azk644XBA/3u wCALEB9My4U3kPmWqVkIC6Ja1FludfYy+UKR9r8EEFUGC51Ta7M0sr1WzDZc0UO9qcbonW jqQ9mHvG/ECe0avFxBACCkBQnwlBp47Kk8IoB29tODjiwB+EnXj+fLklo5rzCQ4OFETl29 Z0WRhn7iDZRR/r3YLZ+srsirDs02Vylqkm3bfArTSYkJlspsNgB0GW+4VLyASIS5FY0DQJ FcXLSQPQWIzGXQqCdXTRemCPQOJwpwj8+xApi5is9PYFeQG9Ke1FCJ6MhP9tkQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748625972; a=rsa-sha256; cv=none; b=e0Mcdd+KBFiGRC0U8Ft0wnQuf+k4Mx5jGhdH6hdHy58VAOHeOmQFaA30o8wHGDsIs/Q81N 4ojEdWzsV1jWWVm6CMt4UuMBgdQ+kN/vYQH11g5U0Wm2mZiShi/Kagq4WAKwBK96jfxV8T 7cRAIErvOvDVrpScha1yFQJbgbgl6hZXbAyrT0S2N9/Ui6UPN8bOox1ALLobxBt1g2i2sU PTxTQjd/5VRPWoXMdBe2yLDkqIOMPcF6LRpbMhzmBT+sKzeGr84J0YWC6K2nWWv8fWXSLF KujCmaXRL2sh9PzkzvfH1WE7VcEIWiG0ws5I5FG7yt9vxNPZL5pDG0L1qJr9YA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748625972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JxBkd/ic5we+MeRJA72l3Y83kkiyv1bxZI/U3KJ/ErU=; b=hXO9J1uVWyW1m6s+1R4qIH5B+KwvednWUZ3wOQ5AMPFXqPrFt57LfoQjMXEpRznVSA9X4p MgnG5gYl7AT7v4fUfSVV/RQAVBzHkDqZsqO+kyzelWkPXaN6x1pgaBFC3je1DptasUHOY0 qyKXbZ0k6fIEO6hdKOFd/DVCdReJfDbK0tl9NL3RcXmzbdoFTyFmIxP/zB/8eLLz6tqM5B AzKOCE9Mj7ZbHSNoTQ6EL6dUPV3smNkGFwBRwnX87jd9HY+Zo1Y7P8KD3Zqx2OUuyHsaiM /CJLek6jAudzMKIRiMD3y3YN8M+k0Ad6ktOuIDvlMMKJpxwzwoK9QJKsTJhN+A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4b89BX0l7Kz12CH; Fri, 30 May 2025 17:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54UHQBp8049529; Fri, 30 May 2025 17:26:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54UHQBPM049526; Fri, 30 May 2025 17:26:11 GMT (envelope-from git) Date: Fri, 30 May 2025 17:26:11 GMT Message-Id: <202505301726.54UHQBPM049526@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 799105f53a96 - main - sound: Deprecate the MIDI sequencer List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 799105f53a9647f86dbf08456260d5850851b6f9 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=799105f53a9647f86dbf08456260d5850851b6f9 commit 799105f53a9647f86dbf08456260d5850851b6f9 Author: Christos Margiolis AuthorDate: 2025-05-30 17:26:01 +0000 Commit: Christos Margiolis CommitDate: 2025-05-30 17:26:01 +0000 sound: Deprecate the MIDI sequencer The in-kernel MIDI sequencer is not used anymore, since this is done by userland applications nowadays. It also contains bugs, and we are not exactly sure how it works, or if it worked properly in the first place. Sponsored by: The FreeBSD Foundation MFC after: 1 day Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D50606 --- sys/dev/sound/midi/sequencer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/dev/sound/midi/sequencer.c b/sys/dev/sound/midi/sequencer.c index 29e01fcaba2f..db49aa1ef259 100644 --- a/sys/dev/sound/midi/sequencer.c +++ b/sys/dev/sound/midi/sequencer.c @@ -519,6 +519,8 @@ seq_addunit(void) int ret; u_char *buf; + gone_in(15, "MIDI sequencer: no longer needed or used"); + /* Allocate the softc. */ ret = ENOMEM; scp = malloc(sizeof(*scp), M_DEVBUF, M_NOWAIT | M_ZERO); @@ -736,6 +738,8 @@ mseq_open(struct cdev *i_dev, int flags, int mode, struct thread *td) struct seq_softc *scp = i_dev->si_drv1; int i; + gone_in(15, "MIDI sequencer: no longer needed or used"); + if (scp == NULL) return ENXIO;