ctually be desired, since > >> doing it the way I did might cause issues if third-party code defines > >> the macro to a value smaller than what libc was built with. I might > >> remove that gate. > >=20 > > I don't think we need the !defined part of it... > >=20 > > But what software is breaking? What's the error message? Maybe the > > fact it's undefined is pointing at a different bug=E2=80=A6 >=20 > Probably include/ssp/signal.h unconditionally defining the wrapper? > Presumably gating that with the same condition as sig2str itself would > fix things properly rather than such bogus hacks. >=20 > But yes, including the actual error message when reporting a build > failure would have been helpful. I apologize. I indeed should have included the error message. It's included below. =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D =3D=3D=3D> lib/liblua (all) cc -target x86_64-unknown-freebsd15.0 --sysroot=3D/usr/obj/usr/src/amd64.am= d64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -O2 -pipe -fno-common -= DHARDENEDBSD -I/usr/src/lib/liblua -I/usr/src/lib/liblua/modules -I/usr/src= /contrib/lua/src -DLUA_PROGNAME=3D"\"\"" -g -gz=3Dzlib -mretpoline -fPIC = -flto -fzero-call-used-regs=3Dused -MD -MF.depend.lapi.o -MTlapi.o -std=3D= gnu17 -Wno-format-zero-length -fstack-protector-strong -D_FORTIFY_SOURCE=3D= 2 -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-po= inter-sign -Wdate-time -Wno-empty-body -Wno-string-plus-int -Wno-unused-con= st-variable -Wno-error=3Dunused-but-set-parameter -Wno-error=3Dcast-functio= n-type-mismatch -Wno-tautological-compare -Wno-unused-value -Wno-parenthese= s-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-type= def -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-pro= moted-parameter -Qunused-arguments -c /usr/src/contrib/lua/src/lapi.c = -o lapi.o In file included from /usr/src/contrib/lua/src/lapi.c:19: In file included from /usr/src/contrib/lua/src/lapi.h:12: In file included from /usr/src/contrib/lua/src/lstate.h:130: In file included from /usr/obj/usr/src/amd64.amd64/tmp/usr/include/signal.h= :76: /usr/obj/usr/src/amd64.amd64/tmp/usr/include/ssp/signal.h:41:23: error: use= of undeclared identifier 'SIG2STR_MAX' 41 | if (__ssp_bos(str) < SIG2STR_MAX) | ^ 1 error generated. *** Error code 1 Stop. make[5]: stopped making "all" in /usr/src/lib/liblua =3D=3D=3D=3D END LOG =3D=3D=3D=3D --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --ogq5fvkdxf2poib2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmhKRh8ACgkQ/y5nonf4 4foEAA/+OqFmcGA8qgv7T+HrQ6jMDwjXfV0p6sxeAtyUii5CxW5oQ1ZS6/eRnF9j eXW3Cc6hSL98HpeZ34sHarWd2oCCYX8pYiD3Uhlo3xI4I+tSTWTeuyIhX+SAJxqP XYIDfTzn82uHpx9D50KlyBK6bGF6x3tMZnAJIAKfHZX6l6wfyq2Ja+VkjBRCHnft YbzbXaPB8cAId9HDSbce7wOtoNeyJESDsPvvG06CVaolAg2aak5YZ0HjjfgfJwK8 hJUi+XJjR1+wLu7CXyaRwU+Y7R7xzKrpF1SsEZq3IDpEUMlY/wq7evQ5t1lis1nu rXAtv9Kkp4kbQhicw3GWML1wXCayjWa++kJ2V+TQ/3GIFI8CRGX4aGNaVDI/xP0s SZpk5DqmcPxKyttKR1YcbWIHyiQqCcmRpVuuQs0YqkvGfsmedc5y+nhm/EO4If6E Pcr0oH6OZBGZtTdNNj+VwVyR3GA+JrxqBVDqgFO4AVKOTEOwEUnfRdTs0y/yvhlg +lGLKwKjetDsSNqIdYURzgTZzCcnt4YIT8+kkXr7M+8/rx08ukKRLB9zVqbemRAT 9gH7cCDOKkn1CZklQseO2wvVkIF5KUH5PZZXgZPwUFclq9lY6JD7pozQEKMbYLrW RpXjiEBjsEVtew9b0qUfLAYIRBL0orqaL5vImuPz8j053muDZmY= =SMcD -----END PGP SIGNATURE----- --ogq5fvkdxf2poib2--