From owner-freebsd-scsi@FreeBSD.ORG Mon Aug 8 15:57:24 2011 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE3101065670 for ; Mon, 8 Aug 2011 15:57:24 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id A99458FC16 for ; Mon, 8 Aug 2011 15:57:24 +0000 (UTC) Received: from [192.168.135.110] (c-24-7-47-62.hsd1.ca.comcast.net [24.7.47.62]) (authenticated bits=0) by ns1.feral.com (8.14.4/8.14.4) with ESMTP id p78FvNNm005484 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Mon, 8 Aug 2011 08:57:24 -0700 (PDT) (envelope-from mj@feral.com) Message-ID: <4E40075E.3020001@feral.com> Date: Mon, 08 Aug 2011 08:57:18 -0700 From: Matthew Jacob User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0) Gecko/20110624 Thunderbird/5.0 MIME-Version: 1.0 To: freebsd-scsi@freebsd.org References: <4E3F0332.7030004@feral.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (ns1.feral.com [192.67.166.1]); Mon, 08 Aug 2011 08:57:24 -0700 (PDT) Subject: Re: some changes to xpt to help make unloading sim modules safer X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2011 15:57:24 -0000 On 8/8/2011 7:52 AM, Chuck Tuffli wrote: > On Sun, Aug 7, 2011 at 2:27 PM, Matthew Jacob wrote: >> See http://people.freebsd.org/~mjacob/xpt_patches.txt > Matt - > > Thanks for doing this. So it seems the rule is to hold > xsoftc.xpt_topo_lock while modifying bus->refcount . If so, does > xpt_alloc_target need mtx_lock() / mtx_unlock() around bus->refcount++ > ? > > By jove, I think you're right!