From owner-cvs-all Sat Jan 6 5:16:30 2001 From owner-cvs-all@FreeBSD.ORG Sat Jan 6 05:16:28 2001 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from lucifer.ninth-circle.org (lucifer.bart.nl [194.158.168.74]) by hub.freebsd.org (Postfix) with ESMTP id C148A37B400; Sat, 6 Jan 2001 05:16:26 -0800 (PST) Received: (from asmodai@localhost) by lucifer.ninth-circle.org (8.11.1/8.11.0) id f06DGPT49320; Sat, 6 Jan 2001 14:16:25 +0100 (CET) (envelope-from asmodai) Date: Sat, 6 Jan 2001 14:16:25 +0100 From: Jeroen Ruigrok van der Werven To: "David O'Brien" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/s3 Makefile Message-ID: <20010106141625.A49254@lucifer.bart.nl> References: <200101060944.f069iUU78655@freefall.freebsd.org> <20010106041016.A75733@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010106041016.A75733@dragon.nuxi.com>; from obrien@FreeBSD.org on Sat, Jan 06, 2001 at 04:10:16AM -0800 Organisation: VIA Net.Works The Netherlands Sender: asmodai@lucifer.ninth-circle.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG -On [20010106 13:15], David O'Brien (obrien@FreeBSD.org) wrote: >On Sat, Jan 06, 2001 at 01:44:30AM -0800, Jeroen Ruigrok van der Werven wrote: >> Log: >> We don't use += for SRCS in Makefiles, we simply use the >> line continuation character and state the rest of the sourcefiles >> on the next line. > >We use both. But if you wanted to clean up the style, it should be >"SRC=" not "SRC=" Yes, that was what I figured, but I also considered it too gratuitous to do that in the same change. Then again, maybe it wasn't that gratuitous to do in the same commit. *shrug* Guess that that'll be a common sense issue like always. -- Jeroen Ruigrok van der Werven VIA Net.Works The Netherlands BSD: Technical excellence at its best Network- and systemadministrator D78D D0AD 244D 1D12 C9CA 7152 035C 1138 546A B867 I know your name, but I am just your Fallen Angel of Doom... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message