From owner-cvs-all  Thu Mar  7  3: 1:29 2002
Delivered-To: cvs-all@freebsd.org
Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3405E37B400; Thu,  7 Mar 2002 03:01:23 -0800 (PST)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.6/8.11.1) id g27B1NY63575;
	Thu, 7 Mar 2002 03:01:23 -0800 (PST)
	(envelope-from obrien)
Date: Thu, 7 Mar 2002 02:57:20 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Mark Murray <markm@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libcrypt crypt-md5.c crypt.c crypt.h misc.c src/secure/lib/libcrypt blowfish.c blowfish.h crypt-blowfish.c crypt-des.c
Message-ID: <20020307025720.A63484@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.org
References: <200203061718.g26HI9060426@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200203061718.g26HI9060426@freefall.freebsd.org>; from markm@FreeBSD.org on Wed, Mar 06, 2002 at 09:18:09AM -0800
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Wed, Mar 06, 2002 at 09:18:09AM -0800, Mark Murray wrote:
> markm       2002/03/06 09:18:09 PST
> 
>   Modified files:
>     lib/libcrypt         crypt-md5.c crypt.c crypt.h misc.c 
>     secure/lib/libcrypt  blowfish.c blowfish.h crypt-blowfish.c 
>                          crypt-des.c 
>   Log:
>   No functional change, but big code cleanup. WARNS, lint(1) and style(9).

As many people have asked in the past, please commit style(9) separately
from other commits.  It is hard to see the WARNS/lint(1) changes from the
diff.

I would like to renew my opinion that WARNS/lint(1) fixes be reviewed on
-audit (or -hackers) before commit.  (also might want to run them on your
local machine for a few days)  You are changing a lot of code for reasons
of quieting lint(1), which a lot of us do not agree with.  And lint(1)
quieting changes can easily become bugs as we saw with crypt-md5.c rev
1.9.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message