From owner-cvs-all Sat Oct 17 00:49:07 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA10309 for cvs-all-outgoing; Sat, 17 Oct 1998 00:49:07 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA10304; Sat, 17 Oct 1998 00:49:06 -0700 (PDT) (envelope-from bde@FreeBSD.org) From: Bruce Evans Received: (from bde@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id AAA04052; Sat, 17 Oct 1998 00:49:04 -0700 (PDT) Date: Sat, 17 Oct 1998 00:49:04 -0700 (PDT) Message-Id: <199810170749.AAA04052@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: cvs commit: src/sys/ufs/ufs ufs_disksubr.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk bde 1998/10/17 00:49:04 PDT Modified files: sys/ufs/ufs ufs_disksubr.c Log: Use only the correct raw partition for writing labels. Don't use the partition that the label ioctl is being done on just because it has offset 0, since there is no guarantee that such a partition is large enough to contain the label. Don't use the wrong raw partition (0 instead of RAW_PART). This fixes problems rewriting bizarre labels (with a nonzero offset for the 'a' partition) in newfs(8). Such labels shouldn't normally be used, but creating them was allowed if the ioctl was done on the raw partition, and sysinstall creates them if the root partition isn't allocated first. Note that allowing write access to a partition other than the one that has been checked for write access doesn't increase security holes significantly, since write access to any partition already allows changing the in-core label. This fix should be in 3.0R. Rev.1.26 of newfs/newfs.c shouldn't be in 3.0R. Revision Changes Path 1.38 +4 -9 src/sys/ufs/ufs/ufs_disksubr.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message