From owner-freebsd-net@FreeBSD.ORG Mon Feb 20 23:57:52 2012 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 14C51106566B for ; Mon, 20 Feb 2012 23:57:52 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id C45B58FC08 for ; Mon, 20 Feb 2012 23:57:51 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 27F1A7300A; Tue, 21 Feb 2012 01:15:52 +0100 (CET) Date: Tue, 21 Feb 2012 01:15:52 +0100 From: Luigi Rizzo To: Brooks Davis Message-ID: <20120221001552.GA60050@onelab2.iet.unipi.it> References: <338757D1-6B1E-49CF-983F-5D5851066FD3@xcllnt.net> <20120220231601.GA51310@lor.one-eyed-alien.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120220231601.GA51310@lor.one-eyed-alien.net> User-Agent: Mutt/1.4.2.3i Cc: net@freebsd.org, Marcel Moolenaar Subject: Re: Abstracting struct ifnet X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2012 23:57:52 -0000 On Mon, Feb 20, 2012 at 05:16:02PM -0600, Brooks Davis wrote: > > The concept seems fine to me and I like that it might simplify future > API changes. Have you verified that if_get_*() accessors don't add > significant overhead? the vast majority of these fields are only accessed in the control path, not on each packet, so there isn't really a performance issue. Besides they can be trivially implemted as macros or inline functions. cheers luigi