From owner-freebsd-bugs@FreeBSD.ORG Fri Sep 5 21:20:06 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00AFE1065675 for ; Fri, 5 Sep 2008 21:20:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CE69C8FC1B for ; Fri, 5 Sep 2008 21:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m85LK5VP020687 for ; Fri, 5 Sep 2008 21:20:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m85LK5Qp020686; Fri, 5 Sep 2008 21:20:05 GMT (envelope-from gnats) Resent-Date: Fri, 5 Sep 2008 21:20:05 GMT Resent-Message-Id: <200809052120.m85LK5Qp020686@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeff Wheelhouse Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A18E21065680 for ; Fri, 5 Sep 2008 21:12:17 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 8C98A8FC16 for ; Fri, 5 Sep 2008 21:12:17 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m85LCHvx047529 for ; Fri, 5 Sep 2008 21:12:17 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m85LCH24047528; Fri, 5 Sep 2008 21:12:17 GMT (envelope-from nobody) Message-Id: <200809052112.m85LCH24047528@www.freebsd.org> Date: Fri, 5 Sep 2008 21:12:17 GMT From: Jeff Wheelhouse To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/127121: pf incorrect log priority X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Sep 2008 21:20:06 -0000 >Number: 127121 >Category: kern >Synopsis: pf incorrect log priority >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Sep 05 21:20:05 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Jeff Wheelhouse >Release: 6.4-PRERELEASE >Organization: >Environment: FreeBSD r2 6.4-PRERELEASE FreeBSD 6.4-PRERELEASE #0: Fri Sep 5 01:22:09 MST 2008 root@r2:/data/r2/freebsd6/obj/data/r2/freebsd6/src/sys/ROUTER i386 >Description: If round-robin load balancing is enabled, pf logs a message indicating which address was chosen for each new state that is created. This produces a prodigious amount of information on a busy server, which can render the server unusable, but the message is logged at priority PF_DEBUG_MISC. PF_DEBUG_MISC is identified as for "various errors." Selecting a destination address is ordinary operation, not an error. Therefore I believe the appropriate log level for this message is PF_DEBUG_NOISY. >How-To-Repeat: 1. Run "pfctl -x misc" on a busy machine that uses round-robin load balancing. 2. Cringe. >Fix: Change PF_DEBUG_MISC to PF_DEBUG_NOISY at line 2407 of pf.c in this revision: /* $FreeBSD: src/sys/contrib/pf/net/pf.c,v 1.34.2.8 2007/11/21 13:52:04 dha rtmei Exp $ */ /* $OpenBSD: pf.c,v 1.502.2.1 2006/05/02 22:55:52 brad Exp $ */ (Patch enclosed.) Patch attached with submission follows: --- pf.c.orig 2008-09-05 13:59:25.000000000 -0700 +++ pf.c 2008-09-05 13:59:59.000000000 -0700 @@ -2404,7 +2404,7 @@ if (*sn != NULL) PF_ACPY(&(*sn)->raddr, naddr, af); - if (pf_status.debug >= PF_DEBUG_MISC && + if (pf_status.debug >= PF_DEBUG_NOISY && (rpool->opts & PF_POOL_TYPEMASK) != PF_POOL_NONE) { printf("pf_map_addr: selected address "); pf_print_host(naddr, 0, af); >Release-Note: >Audit-Trail: >Unformatted: