Date: Fri, 10 Sep 1999 16:51:34 -0700 (PDT) From: Donald Burr <dburr@Powered-By.AC> To: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Advice needed re: committing some ports diffs... Message-ID: <Pine.BSF.4.10.9909101645580.25659-101000@Generator.Circuit.Powered-By.AC>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-179121474-937007494=:25659 Content-Type: TEXT/PLAIN; charset=US-ASCII Hi. As you may know I recently committed a port, audio/ripit-atapi. This is a modification of the audio/ripit port, to use cdd to rip tracks from CD's instead of Tosha. (hence, this port is usable for those of us who have ATAPI CD-ROM drives.) Upon committing the port, several people e-mailed me saying that it would be a good idea to add Gogo (audio/gogo) as an MP3 encoder option, because it runs much faster than BladeEnc. So I went back to the drawing board, and modified the *original* audio/ripit port to fold in my ATAPI changes as a user-configurable option, AND add Gogo as another user-configurable option. I have tested this new port on all of my machines (I have both SCSI and ATAPI burners), and have had no problems with it. I have e-mailed the maintainer of the port, to see if he would give the OK to commit these changes, but there is no reply. I think it would be a good idea to fold these changes in, in time for 3.3-R. That way, we can get rid of the audio/ripit-atapi port (which, in retrospect, was probably not such a hot idea) and have one port that does everything, based on whatever knobs the user chooses to set. So can someone advise me as to what to do here? Should I wait on this, or go ahead and commit it? Can someone look at these diffs and advise? Thanks! -- Donald Burr <dburr@Powered-By.AC> *NEW!* FreeBSD Dev. | FreeBSD: The WWW: http://www.Powered-By.AC/ *NEW!* ICQ #16997506 | Power to Address: P.O. Box 91212, Santa Barbara, CA 93190-1212 | Serve! http:// Phone: (805) 957-9666 FAX: (800) 492-5954 | www.freebsd.org/ --0-179121474-937007494=:25659 Content-Type: APPLICATION/octet-stream; name="ripit.diffs.gz" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.BSF.4.10.9909101651340.25659@Generator.Circuit.Powered-By.AC> Content-Description: Content-Disposition: attachment; filename="ripit.diffs.gz" H4sICN6K2TcAA3JpcGl0LmRpZmZzALVZe3PaSBL/Gz5Fh3AJFBIgwA8g9tox Ts4Vv9Y4693a5FxCGkBloWH1MKFy3s9+3T2SEK845a1z2UaM+jU9v37MjO0M h6D70SX4ztQJq9K1axfmgxg6rlBD6de8rusbqHIffAf6YgpGHYydTnO3Y7TA aLfb+UqlsiJihba132nGtEdHoBsNDVkr6uPoKA95uDg+u7zFv9Obg5ycPzqe PZFHjueEjqx6Ein0m8+X973T69PLXv8gN3BNWwjP6hS/X1/d3PZ7ZzdPNTOy HVlLXsGXvJ7LhTIYmxuoeFyRWPYmgm8Ty85XlpT+gBBncHl1//7z2XnvIDcX QR4+90/vr09vznfi73mwpe54QWi6bicPuSMofj+77N8en5/f909uzq5vn3Dk 7uZT/+bkqaa8P3Vx6Prm9MPZ70+1gePlK8x2fvkEejBcfreFRQ3HjCfHrOT6 00e2/+K03z/+eEq2VR3PciNbwLtBYFen0g+rk4fDvL0BNFMztMYiUJ+6acYr vzq8AqLV1z8Dpud42p3WbgZU2i5CSjPahCh9oX3qVqXvjHJ3wmZmMMBodnaM Tj1m1lONSLtK1uwYjZiMlDR2NVReUR+op7KuZ8XI/U5jJ51YRs8KWatDD0zG k9nn2exrqJ3UwGtQP7pui0fHErDyo8NJ7+bqAuK3oSRNMPTlhJhZwG/CDxzp gVHdgbpRq+/X2m3k6zsTHPw1cjzEV2WJzB40oN6uGXVF2ZOe6drwPvJ9eGcP 8OPogy/E+36venXz8ZC4cxcSMeOgD9EC07bB9EBOQ5KHA1EgwMJBCgNh2iCH wHGowVD6zB6OJdLgeBRAKfJwOIw8MxQgPBmNxmWYjSWMzUcBx7fH12e1s94p TlzHmQdVFnArUDRK9iA2DWZOOIZwLNIBsoAQDqVaFPg1egziWMZXZY3l/HFx 8Rs4Q5jLCExfoD2ONwITKCKEL7wQrvrVzTNGZY5vo8WWtIWfTF+HkRzJV+lq fA7MkeikeIA/dX1suuFXehg4oU+Tpn9fIbP6ix+kmgvTB/rHPPHC4wz4Accw 1fjhPUqyHr4qVMXobWLebXLeZTvQRkt6Q2cU+eYAi8Gj6Tv0ENB7/FPRVdcw g1caTc3YVbyVoozCaRTajg+5AyjUxnIiapNps1bo5nKv4W6MfmLHX1w3AwjG MkLwjDCXQzGeILIZu3WkRvL38ZxxyZkhD3oxdiGRdYGp6ujH93GC1zBEdTg3 J1iwKhna+o9pK5UiOn2KpEybksZIJDp0IpH9rEgNGvj0EZeXuMyJ3bQ9OVtI /yhDioPjix582tX/bDS/1j7t1Y7DsSu9X6DU7F3KWRlZczkmNw6wYGhQP6C6 B+QujJv7yENTAkuiT1kwrxzcZ2MpmJqWCHAEqAR7aBkGkQFKGniyTOI4jTUb ba7A/GlwhuFF3jW0PUw7e3XMPpx21I/tCCjcEpAgEK6wGNBjZ4QrjAuMU/Oi yYCgjvFMVEGhG/M+8Sf+1/GBvij8s7K9ptamHGdobaWMaYM5zmdSKvgTKIbS 4vbksIagrnmR60Lj8I1RKHeZWl9QY2kGCgEocgBQ/K8xQfeHLKgMDhOVz1JL LIwbNVQ28XxnpqetZv2QaYNhP1ayzTTlYExqJXiFVX3h3zJ8V2ucjjgBTJyA cl6hy+v2FGeQ1i4hpLHTWkYIwDQKxnDEy+86QaglgClUg6nveOGwVPhXvWEX tFLxdUoFFWiUy91UzNMCNuj7BDvqwXKpNJz0bq9Oukk6a7Axu+3EGCZ8DT0n mLrmnJMPklNmDizM/t4SwiwzhHcLv3Y3gbRpcEQ0jb3sfMmFa0GJSYr8SMkl 9Cn44OBvCGpQu6+NuotpAPgijHwvQ5hqpvBkkjfKZS76tISt4fnVR61wg0mL alAx9d6fxXvMO8bXarX6xVNBkZjd2NOMHbQbU31zf2G40onsyj54MxJxhaCB UvFe2yA+XZ8Ft0Te4n0ahS83uJK6U+Xk2I3wPX7Fy3nS62HzLALvbahqv+nN YYpuDOdQmI1xGVkDgXYgSCPLsn8pZIWoYqVBIGEmsCnAyAimYkbjjBMlgv0i Ix/T3CMXQCxDiYmLiJuavulJhwIvyQdZ33wpLPm5il++FAplREcsbYvDMoKH JmKS25h17ynXpZI4cH+SFfOyXlmdj9oKLaaiD2Fm4ke4NCl9fV5IlcxLr/xg XkrB81PSl+rN81yF7mKBWS2kmFOruQ156L04zaQL/BpuuGKqtplSILVz7Ajq SOJWICb2Fen6Mhe0dReRz/XY0BeHyeZIqa9Gyi35rArwhzmvLrj+D+tdWST+ f7TkWTkvWPWn+PEJhIvFYckXdyLTuGMKQbechWCZlEVGwhPcbd4d/4ZJYw5O iBE/jLNDVsokwirleI/yQfWyI1+Y1M3ZWB9HY0xA/avfUfLtGJMP/kYjd47L tmIHJy3E0yTyRmjRlCXFDbvHDeRAWGayO5qZXojCSG1WDvEgFCfw1rTs+lsN G7oQ3nKdpwHrLZrRR5uyyrP8f0RTjbYmbGecPT0zCFeQQqAgVBzE8OhueEV1 7T9fSPWXml+rbSOxikvvlnOovQa4vwiJiQAd+5ZFD/NfXJhvxGDZPr76B8Ak xS+A5XNsG0FJ5XG7JRj3uO+aTF2BONya5ZOO4DX0aTvHKDiNd5bY6NPXAXKO fIm9SBUGWM2k587xnyXiXn93j1uY3RZ+JJ1+s9Xiwb3Gch9X5E0jnZ7Rnisd jjzcDuJmAvH3QE3OG6S4t+xSubvUsqUNm+p2WNHOPiva30kUBdEAFDstFzJM 5qWioxW/aUWcV+SFGm28khafKVCtMK0xlI4wStlTvNTwT7uarHvaTeUeNeG4 nHzxcCuq/L2oKoVqbGi1QDueQhU72sQubGiNcrWQqTGblj4V+IOcn6lMn4SY gisllwnU67gqGVCVMrEWmD5u8BClMxOTBlWrRTcQ19QXyOBEHCP5BeyqSOXT 5OVMBHVa5jBE4DbrmD29KOQOi1fw20E9cdhsjELjHcqGagrl7wm09vb5OKNV b8WnfikiMFqEipXkFGamqsFI8jryUVS2mU/IVFFdpBHavOOvBiPTRlSpzT8u 36tFxKhgKaTHzvqvn89uQU/OODYnKyh04875Kf5cKmBcz1YNW+6LU8s+Ksvo IGLdKpciQh/AM9asjk6mTUyo3W3VlS1Lzjk2tOzr1tHhyCso3dFZHJ93vNJA PArvVTnLlVhNJ2VLVuuoiRLvS6zf1B1sNZDyJ9YiNhE6Jfg5815oVuaMJINF RH5SJVnhIf135Yg38vAuLYpxveNIaLcph7WaK7vyTbknTWgIqg/PF8JYEhfB n2XNnv4sagJC/Bsmh+7iMKHV2mGz99pZs3HygRAPcHap0f5bg0auS4Mz30FX 0+jUtIMQZzYqFQpas17Gv+4m5k281tgvFbH980VZW1Q4dbZwdrl8BkCVKtWF vt54G/IwqvVO+yc3yZ1F8n31/iMZ/6mLjy3ELaPTaixuPPj8rBlfEWC5YGbq 7kwIJia2TUNfeqEusFmd+nLkmxMgR2B5p9YB07ObpmqcoJZXyZLm+gZCczSi JzqKrVLjzGIt6QUSU34iLqTNtyeEHVDUYE718zoiTvgY2nRIyJy++CtyfBEk J6xppqQumm7PuK+gFv09mJaFjUYZW9LtYkwkjUtxvBVi/v5J/wxs33mk405O 79mTfdbd5fnyzQGTwNrZP9tkejTtfCXJvaVBeuTrcrdORJwEqKQE0ZTECBut xkW4u7vrwDgMp51abTabVT0RYpcXPVQtWY0ean8Hf9FNS3xbNw4nLjHhBhGu 6UoCtyJXfPsJFxIX8N36VehhvsI3GmNhPs5hwpcPlkle4o3Mc3c02zAc3wVm AJjcDq7jOH7DV2U9YUHTAGO3U6/jL4JzdxXJCfkKllud5v4Cy3Wtzrd3O5wI 3gtq+fjyBTdsvFS8cyFHazzM+zJbxrsi15UzRGsnjxsZA/dB1w6CYw0ntANU NzrqFElBRl0fKTzETQ+lhPXLIX5ZXhXird1EaYvmgrYNm2+ZqmRqIzWVEZc0 Kzh6gguH2HfnWtpybBCU4JLurEjd+fHF6QYyAm0MbSpzGygIzGVCs5KTQhot OaXGe2zShhRDz37Ezak5oihEabYTLEZ488z5RwnxBeJ+gsmHrsYoT5DPfLqq 4N2vtCJ8GTJyqY3mBn+g1h3Ti4VJBVeU3dQkM2wUveXCm0wJ4n4vvcliuelV FrV8qN9XptkiwExiLxPzLl7MOaZnAoNPmU9eICP+jW3uPMmVr7bG0fX5Wf82 A37+viGGePxna8Em4hbRZ26/KXrUXfHi1h+ybsr/D/iFTSYCIgAA --0-179121474-937007494=:25659-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9909101645580.25659-101000>