Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 7 Mar 2017 18:12:27 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Kurt Jaeger <pi@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r435626 - in head/sysutils: . lava
Message-ID:  <20170307181227.GA51594@FreeBSD.org>
In-Reply-To: <201703071801.v27I1EPH079048@repo.freebsd.org>
References:  <201703071801.v27I1EPH079048@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 07, 2017 at 06:01:14PM +0000, Kurt Jaeger wrote:
> New Revision: 435626
> URL: https://svnweb.freebsd.org/changeset/ports/435626
> 
> Log:
>   New port: sysutils/lava
>   
>   Keeps your CouchDB views molten hot and fluid.
> [...]
> +# PORTREVISION=	0

This line should've been removed.

> +COMMENT=	Keeps your CouchDB views molten hot

Questionable COMMENT, yet (see below)...

> +do-install:
> +		${MKDIR} ${STAGEDIR}${DOCSDIR}
> +		${INSTALL_DATA} ${WRKSRC}/README.md ${STAGEDIR}${DOCSDIR}/
> +		${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME}.sh \
> +			${STAGEDIR}${PREFIX}/bin/${PORTNAME}.sh

Broken indentation, could you please fix it?

> @@ -0,0 +1,8 @@
> +Keeps your CouchDB views molten hot and fluid.

COMMENT (almost verbatim) should rarely be part of the port description.

> +Lava is a simple MIT-licensed shell script with 2 dependencies that
> +ensures all DBs that are readable by a given user have the views
> +of their corresponding design documents rebuilt. It is intended to
> +be run regularly from cron.

This paragraph alone would've perfectly sufficed.  Also, perhaps cron(8)?

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170307181227.GA51594>