From owner-svn-src-head@FreeBSD.ORG Fri Feb 27 17:15:58 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 998A2D86 for ; Fri, 27 Feb 2015 17:15:58 +0000 (UTC) Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5892E934 for ; Fri, 27 Feb 2015 17:15:58 +0000 (UTC) Received: by pdno5 with SMTP id o5so22378502pdn.8 for ; Fri, 27 Feb 2015 09:15:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=oIKlH/Bgdlml+kUnOGpV1y9gf7WK7kotL4m/kOMGwEk=; b=JrG0qY5NA5YHEkuyxawhFm2kRcHN6j4V7yuxqwpvi1zlbAf+NUqUskcUerqOjLf6jG 6kBRjWFp0IUdEe1z2vzWgB4fIorHdcHSYZV3Lb+CnvidYyA6wHKAAv8zhLaF59nvKVTn jIklaJiiVT2hy7v9molZ4mtI+LHG59rD+l04GCaAaCWvyQMW2ihK6oDt5pP0n/VdE3B1 Uv2FaM9XrhTUgCqkFJc/eHHxKCEnBoHJEj0bAQqcnfBlGOFosxGnQWb5WR9fqbt8itWf 9+/I+tdGe43N5aiHhQ2z2vsBdrf1X5P/yECNzelBPUgUMHnJRqg6LVq2erTltAJc4kJ4 3QVw== X-Gm-Message-State: ALoCoQn7nszMF/Mp6KTM8zHuxjd4o0Jl4EfCpVp5lyt9+swAWeCLiq0KXEAeys6us/st53D8Itps X-Received: by 10.68.142.169 with SMTP id rx9mr25348182pbb.41.1425057352167; Fri, 27 Feb 2015 09:15:52 -0800 (PST) Received: from [10.64.26.6] ([69.53.236.236]) by mx.google.com with ESMTPSA id k14sm4494182pbq.53.2015.02.27.09.15.50 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 27 Feb 2015 09:15:51 -0800 (PST) Sender: Warner Losh Subject: Re: svn commit: r279349 - head/sys/kern Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_DEC43D1F-739A-484B-A2F8-6BECDDF10619"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b5 From: Warner Losh In-Reply-To: <1425052560.1281.21.camel@freebsd.org> Date: Fri, 27 Feb 2015 10:15:48 -0700 Message-Id: <4EB4F8DB-77DC-41CE-9678-1D6710A5F058@bsdimp.com> References: <201502270256.t1R2uxnv085328@svn.freebsd.org> <20150227082257.3fb1081c@bender.Home> <20150227202646.I2088@besplex.bde.org> <1425052560.1281.21.camel@freebsd.org> To: Ian Lepore X-Mailer: Apple Mail (2.2070.6) Cc: Benjamin Kaduk , "src-committers@freebsd.org" , Ed Maste , "svn-src-all@freebsd.org" , Andrew Turner , Bruce Evans , "svn-src-head@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 17:15:58 -0000 --Apple-Mail=_DEC43D1F-739A-484B-A2F8-6BECDDF10619 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 https://reviews.freebsd.org/D1981 contains the fix. Please continue the conversation there. I believe I fixed everything, including a bug in the original code. Warner > On Feb 27, 2015, at 8:56 AM, Ian Lepore wrote: >=20 > On Fri, 2015-02-27 at 08:46 -0700, Warner Losh wrote: >> Sure wish my code review got this much love=E2=80=A6 >>=20 >> Warner >>=20 >=20 > IMO, the biggest problem with phab reviews is advertising them. You = can > guess who might be interested and add them as reviewers. You can try > posting a summary and the url to some mailing list. >=20 > I wonder if it would be useful to have the system itself mail the > summary line of every new review that's created to some list? It = would > probably need to be several lists -- I sure don't want to see every > ports phab that gets created, but getting a single mail for every src > review created wouldn't be too much. >=20 > I don't know if that's a good idea or not, but the reason we reliably > get post-commit reviews is because the changes reliably appear in = front > of everyone's eyes at that point. >=20 > -- Ian >=20 >=20 >>> On Feb 27, 2015, at 8:30 AM, Ed Maste wrote: >>>=20 >>> On 27 February 2015 at 10:12, Benjamin Kaduk = wrote: >>>>=20 >>>> As of r278229, the kernel is compiled with -fwrapv, so signed = integer >>>> overflow in the FreeBSD kernel is defined behavior. >>>=20 >>> This is primarily a workaround to accommodate existing code though; >>> it's not a result of an explicit decision that we want to support >>> signed integer overflow. >>>=20 >>> -Ed >>>=20 >>=20 >=20 >=20 --Apple-Mail=_DEC43D1F-739A-484B-A2F8-6BECDDF10619 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJU8KZFAAoJEGwc0Sh9sBEA0V0QAOh9+gYIOUSX7A7lg+W57fQF 4nx9XAuepa5Z7b8HtIiZWZlzjVS68frilns/l18ad4fLkRr6ciZxFA6BMG44m7u3 ih7LdNXOrOdO5NGQurRwO79buFAM4Nojouh6yUkeYjTA8Y2XePiGSILsXqS0jOEi NKGIvDb1lEKoVOFzU86DpcaRczzH2DQg3LBF6SJxTkl05ov0wC6qLhqO2TZ3uUk1 DzRwyq7aTJcVFElrmjVQ70R17mJpqf36xt8G63Tj2TiWaHlSqAmYVy3+uOybzb0i QKxYR1ij5nE6YDsOdQXv0tvH39gDrDy4XkDu+YoKY+QvOPvbb6RZpRGtIWv2tJyB 3TOHi7wDgrs8dNCRNxESMgCwFex7CVf8esFJk1vd8OX9u+qyNDBKLXl5JcH5Nd5a Q3WRO+0nEstDVi8qAH8OrL9xLi7OpgZ5V1Dz5UoNwwYobaLibfYt8zymknCHfOfG Pg/QpUEKVWBiytKm/KXmhNjwN0srypLalbhycM2k40En0DMJHQuvTRMdcDH3+Uyf DDNq+ngNg2u3DsEVUctEcpkVvEv7QvPQsqR0CxN6EZVNRSQ5EuPpiXfLYtPE5hYn Tq0iY9Foxx4K7UgVrYIS0+7QSub4Eky94v1m5yDXa2RdYZEqoRFf2fj/TqzhhRvu gfX1b2WMck6aEcq3saSu =P/Mw -----END PGP SIGNATURE----- --Apple-Mail=_DEC43D1F-739A-484B-A2F8-6BECDDF10619--