From owner-cvs-all Sun Dec 16 16: 5: 4 2001 Delivered-To: cvs-all@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id F3CC737B405 for ; Sun, 16 Dec 2001 16:04:54 -0800 (PST) Received: (qmail 30484 invoked from network); 17 Dec 2001 00:04:53 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 17 Dec 2001 00:04:53 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <3C1C35D4.1070501@owt.com> Date: Sun, 16 Dec 2001 16:04:44 -0800 (PST) From: John Baldwin To: Kent Stewart Subject: Re: cvs commit: src/sys/dev/ata ata-dma.c ata-pci.c Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, =?ISO-8859-1?Q?S=F8ren?= Schmidt Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 16-Dec-01 Kent Stewart wrote: > > > Søren Schmidt wrote: > > > sos 2001/12/14 13:28:50 PST > > > > Modified files: > > sys/dev/ata ata-dma.c ata-pci.c > > Log: > > Adjust the timings for the SiS chips a bit, also add the SiS 645. > > > > Cosmetics on the Acer chips (print right modes) > > > > Revision Changes Path > > 1.78 +9 -8 src/sys/dev/ata/ata-dma.c > > 1.22 +8 -5 src/sys/dev/ata/ata-pci.c > > > > > Your change has a cosmetic error in the line in ata-dma.c. You have > > ata_find_dev(parent, 0x06451039, 0x00) || /* SiS 635 */ > > but the comment should be for a 745. The 745 chipset line is missing in > the ata-pci.c module. Eh? I submitted that cause I was testing on a SiS 645 chipset. :) Perhaps you need to add the 745 as well then in an additional line. There is definitely a 645 chipset though, it is for Pentium 4 systems. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message