From owner-freebsd-git@freebsd.org Thu Dec 17 20:48:47 2020 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AE9044C4283 for ; Thu, 17 Dec 2020 20:48:47 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CxkcG5RdTz4mFk for ; Thu, 17 Dec 2020 20:48:46 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f53.google.com with SMTP id z5so28864183iob.11 for ; Thu, 17 Dec 2020 12:48:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=qWm/rtUtb939VjAxHTzGY0Ls3OgxMLtHGMrzS7P1tnc=; b=kVxGXf8nKBiBLtOEyF9gyZrr/y6S6/+kD5F5Ihxt/zdTOMoWbhhXYBcbZmTVdQAMWs 1CgNuwem6vFSqXXdaHa+pIFJYl/wFt+ZkT1Di5idY6PjpO2ELVrmBziwNgmy8/Md/t0R 7Fzm/L8tZ8+OGyxhHfOZb6HvU89pDk7mqpLthvPNHcAKo7JI4UwWzYun6Jdq8Lh8oxRH 6wBFZHPeNApHJmBS5sxT+spun4Nv/1yzZ3JfygGLoFO6X1rEu5wSozCfFpD2nTIWnxBJ vuvKc6sD9idfb8TFBaXwMZ+U/X/VJDuctEUa4ujIeCmF+veWgQE83SsSZr01xaBRsT06 yOGw== X-Gm-Message-State: AOAM532DWlVxDuwSPRhDe1ajoolQhTZQe8AdKZruijoheOHmal2EZUUV tBF9wk0tb672RYQYz8pztr29ro8IvL9KDayKqD3impTupBw8kQ== X-Google-Smtp-Source: ABdhPJyLf2bNgyLLuhQbDk5sQwC+80vmoNKEAegX/1XGT1dSaWcaUJ2rrxVPrfyBjs93cceU0aUt90EERMysu+BVXOQ= X-Received: by 2002:a6b:b5d2:: with SMTP id e201mr951218iof.111.1608238124838; Thu, 17 Dec 2020 12:48:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ed Maste Date: Thu, 17 Dec 2020 15:48:32 -0500 Message-ID: Subject: Re: Git commit message templates To: freebsd-git Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CxkcG5RdTz4mFk X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.166.53:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; TO_DOM_EQ_FROM_DOM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[carpeddiem]; R_DKIM_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-git@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[209.85.166.53:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.53:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.53:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-git] X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 20:48:47 -0000 On Wed, 16 Dec 2020 at 11:58, Ed Maste wrote: > > One outstanding Git transition item is work on commit message > templates. We currently have an SVN template that lists the metadata > fields we use, such as PR:, Reviewed by:, and such. Git supports local > commit hooks (in .git/hooks) and I've made a trivial port of that to a > git commit message preparation hook. I imagine we'd have these in the > tree (in tools/tools/git/hooks/) and provide either documentation or a > script to install or symlink them into the user's .git/hooks/ > directory. > > The current trivial hook is open in https://reviews.freebsd.org/D27633. I've now committed this to tools/tools/git/hooks, and it can be installed by placing it in .git/hooks of a doc/src/ports repository. (If you're using worktrees then it's the .git directory of the main repository, and the same hook will be used for all worktrees.) To install it you could run: % cp -p tools/tools/git/hooks/prepare-commit-msg .git/hooks/