Date: Mon, 6 Mar 2023 20:52:54 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Koichiro Iwao <meta@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> In-Reply-To: <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <ZAWLnDz5cb4vIR/j@FreeBSD.org> <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
--bfumt7havl2hhsus
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Mar 06, 2023 at 11:25:06PM +0900, Koichiro Iwao wrote:
> On Mon, Mar 06, 2023 at 06:43:40AM +0000, Alexey Dokuchaev wrote:
> > On Mon, Mar 06, 2023 at 04:32:37AM +0000, Koichiro Iwao wrote:
> > > commit d69b20995dec38f96ef28522bc6156a7d5b80fff
> > >=20
> > > security/softether5: add DEBUG option
> > >=20
> > > [...]
> > > +.include <bsd.port.options.mk>
> > > +
> > > +# CMAKE_BUILD_TYPE is automatically set by Mk/Uses/cmake.mk
> > > +# just set WITH_DEBUG=3Dyes, CMAKE_ARGS+=3D-DCMAKE_BUILD_TYPE=3DDebu=
g takes no effect.
> > > +.if ${PORT_OPTIONS:MDEBUG}
> > > +WITH_DEBUG=3D yes
> >=20
> > We do not expose this via options. To build debug package, just
> > "make -DWITH_DEBUG", don't ask users to fiddle with options.
> >=20
> > ./danfe
>=20
> Really? What's the difference exposing ports vs not?
WITH_DEBUG is a global user facing knob, it must never be activated via
options.
--=20
Mathieu Arnold
--bfumt7havl2hhsus
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmQGRJZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1
NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d
Qb6h8QwAsQ57WwBQMkdxwh2VgrXCTqKvW8iDnIHbBdYr9eZzWAZvmnvTt9VG6ZvJ
xfztNoydkfcVOqma33s3ekT9g1Xqg1WCSndx9sH50Y7Dgo0A/lgz9pmzoV06tKuc
N6LXaxy0GH7Y1DGLHq9izbUnGZ/RhnAB2gphpuBcbsWehTMzfYYasLQl1WNlsJDV
EdvC3mjMGfCx6IX3Etg5DiGKwPf4Co5LCpYKeQ6+0iejkOpy94ELUVW+Z9XDPccQ
1A3GJGjci1dStJUThRg2S/f21sE37byFw0cOVCvGYwvVWvEAM3/A7iUgAXQv59/L
69F/9AlV/anId+QZDx5lITxUOyp3Q7EHcZQddBEWMc7++/dL7udHbu14UDt4+znw
IDX6fhXXjsogkGR5thE+e58RfZ46AkbqSh7JHPJwtZhzA46FElE2ayNBUxrA59Da
lhfgufbnWq/zPCE/8dp82QZJia5zdbEziLLLEK2WZA3XKyYPQabLdwphZoVMdl/H
xElIZmiN
=+Nqe
-----END PGP SIGNATURE-----
--bfumt7havl2hhsus--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230306195254.n3gxqbchj5voyypw>