From owner-svn-src-head@freebsd.org Wed Feb 21 02:40:55 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE66BF22617; Wed, 21 Feb 2018 02:40:55 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 436337F620; Wed, 21 Feb 2018 02:40:55 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f51.google.com with SMTP id 37so246524lfs.7; Tue, 20 Feb 2018 18:40:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pFhtBhCKD6ojDqqiZl4Y2E2KCTuTjWmcZrw3G+Pxfmw=; b=o9WFYJn11VUkekWDXCytaLy6aNUv2H64wDkmMqg2iPMhXZlExEhd/opEyALhThM2N7 u0NVjCJCImE0ytZkVn3nje5sinIu4azcFL9KAlHXx6QsH3uJK7xMR/OHzXDSRYX+5EUV UsjpmLsCeGy1nRuOFn53/4gTKsG+NrElaI5uHy6i6IYMsBluF9RhPD34z9HciAmKz8wL tIM6KSqa5FXcJe2f6oGUKiGfZU5lTSHN8q8CQT6UivK0d7aLlJPKSsCz51WgoKSKlaky kWx+hCZxz8NkbxkV74EiqHgFkchHYUehpm5YuTYSkJJ3v0I7qXataf/JcEtet/mhmWkx xrFQ== X-Gm-Message-State: APf1xPAUKGDcQI9IEeHLbyHnFHnthRhzqg7fN1ArhO9rzjEe9NnUPmNg nPb9cwzsqGJe/hQ8wTMFW1pL4IHP X-Google-Smtp-Source: AH8x226lCaNjxiBvakgskG33oF5a1SW4nLs/M7E0oa5esEb9MKnpmEWpC2bF+zUyB5V47FcaSvbwEw== X-Received: by 10.25.83.10 with SMTP id h10mr1201815lfb.121.1519180852785; Tue, 20 Feb 2018 18:40:52 -0800 (PST) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com. [209.85.215.52]) by smtp.gmail.com with ESMTPSA id i8sm998274lfg.90.2018.02.20.18.40.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 18:40:52 -0800 (PST) Received: by mail-lf0-f52.google.com with SMTP id x196so236550lfd.12; Tue, 20 Feb 2018 18:40:52 -0800 (PST) X-Received: by 10.46.114.10 with SMTP id n10mr1167658ljc.74.1519180852353; Tue, 20 Feb 2018 18:40:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.46.106.8 with HTTP; Tue, 20 Feb 2018 18:40:31 -0800 (PST) In-Reply-To: <201802210235.w1L2ZEfG039759@repo.freebsd.org> References: <201802210235.w1L2ZEfG039759@repo.freebsd.org> From: Kyle Evans Date: Tue, 20 Feb 2018 20:40:31 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r329692 - head/stand/lua To: Kyle Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 02:40:56 -0000 On Tue, Feb 20, 2018 at 8:35 PM, Kyle Evans wrote: > Author: kevans > Date: Wed Feb 21 02:35:13 2018 > New Revision: 329692 > URL: https://svnweb.freebsd.org/changeset/base/329692 > > Log: > lualoader: Bring in local.lua module if it exists > > Provide a way for out-of-tree users of lualoader to patch into the loader > system without having to modify our distributed scripts. > > Do note that we can't really offer any API compatibility guarantees at this > time due to the evolving nature of lualoader right now. > > This still has some utility as local modules may add commands at the loader > prompt without relying heavily on lualoader features- this specific > functionality is less likely to change without more careful consideration. > > Reviewed by: cem (earlier version) > Differential Revision: https://reviews.freebsd.org/D14439 > Some discussion from the review that I meant to add here: I imagine this being used for more cosmetic changes, rather than functional changes. Situations like other projects wishing to modify logo/brand availability or adding custom menu options without maintaining a full fork of lualoader. At some point, progress will slow down and we'll be able to figure out what we can guarantee API wise. Documentation will also come, probably sooner rather than later.