From owner-cvs-all@FreeBSD.ORG Tue Jan 20 11:49:11 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0522816A4D0 for ; Tue, 20 Jan 2004 11:49:11 -0800 (PST) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECFCC43D49 for ; Tue, 20 Jan 2004 11:48:50 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 27220 invoked from network); 20 Jan 2004 19:48:49 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 20 Jan 2004 19:48:49 -0000 Received: from 10.50.41.236 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i0KJieMK014221; Tue, 20 Jan 2004 14:48:40 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: "Poul-Henning Kamp" Date: Tue, 20 Jan 2004 14:45:24 -0500 User-Agent: KMail/1.5.4 References: <8219.1074623036@critter.freebsd.dk> In-Reply-To: <8219.1074623036@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200401201445.24897.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2004 19:49:11 -0000 On Tuesday 20 January 2004 01:23 pm, Poul-Henning Kamp wrote: > In message <200401201234.45472.jhb@FreeBSD.org>, John Baldwin writes: > >On Monday 19 January 2004 04:27 pm, Poul-Henning Kamp wrote: > >> phk 2004/01/19 13:27:11 PST > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/alpha/alpha support.s > >> sys/i386/i386 swtch.s > >> sys/kern kern_shutdown.c > >> sys/sys systm.h > >> Log: > >> Add linenumber and source filename to panic(9) output. > >> > >> Ideally a traceback should be printed too, any takers ? > > > >We already print a traceback if DDB is in the kernel. > > The traceback doesn't make it into the msgbuffer, and therefore > many bug reports give no details. > > >We already print a traceback if DDB is in the kernel. Given that panic > >messages are already largely unique and greppable, I think this doesn't > >really buy us all that much. > > It saves the PR-washing team a lot of grepping. I doubt it. Most of the bug reports (and PR's) that I've worked on, the submitter usually doesn't provide the panic message at first anyways. Secondly, probably at least 80% of panics are page trap faults due to a null pointer dereference, and having a source file and line number for trap.c just serves as even more obfuscation of an already busy panic message for a fatal kernel trap. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org