From owner-freebsd-bugs@FreeBSD.ORG  Tue Mar 30 08:30:09 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 74995106564A
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 30 Mar 2010 08:30:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 64CC18FC19
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 30 Mar 2010 08:30:09 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2U8U91k096018
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 30 Mar 2010 08:30:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2U8U93Y096013;
	Tue, 30 Mar 2010 08:30:09 GMT (envelope-from gnats)
Date: Tue, 30 Mar 2010 08:30:09 GMT
Message-Id: <201003300830.o2U8U93Y096013@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Garrett Cooper <gcooper@FreeBSD.org>
Cc: 
Subject: Re: bin/144411: [patch] mtree(8) doesn't reject non-regular files
	for -X
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Garrett Cooper <gcooper@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Mar 2010 08:30:09 -0000

The following reply was made to PR bin/144411; it has been noted by GNATS.

From: Garrett Cooper <gcooper@FreeBSD.org>
To: bug-followup@FreeBSD.org, gcooper@FreeBSD.org
Cc:  
Subject: Re: bin/144411: [patch] mtree(8) doesn't reject non-regular files for 
	-X
Date: Tue, 30 Mar 2010 01:21:58 -0700

 Hi,
     I'm not 100% satisfied with this patch now. Looking back it fails
 the following case:
 
      -P    Do not follow symbolic links in the file hierarchy, instead con-
            sider the symbolic link itself in any comparisons.  This is the
            default.
 
     I need to add a check for this option to the patch, use stat if
 the `follow links' state is true, otherwise use lstat.
 Thanks,
 -Garrett