From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Mar 5 04:10:01 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7097A1065678 for ; Wed, 5 Mar 2008 04:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 47FC18FC1F for ; Wed, 5 Mar 2008 04:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m254A1c9024514 for ; Wed, 5 Mar 2008 04:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m254A1it024513; Wed, 5 Mar 2008 04:10:01 GMT (envelope-from gnats) Resent-Date: Wed, 5 Mar 2008 04:10:01 GMT Resent-Message-Id: <200803050410.m254A1it024513@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Josh Carroll Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 640401065670 for ; Wed, 5 Mar 2008 04:04:45 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 4DEC88FC24 for ; Wed, 5 Mar 2008 04:04:45 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m2541ic7055808 for ; Wed, 5 Mar 2008 04:01:44 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m2541iCx055807; Wed, 5 Mar 2008 04:01:44 GMT (envelope-from nobody) Message-Id: <200803050401.m2541iCx055807@www.freebsd.org> Date: Wed, 5 Mar 2008 04:01:44 GMT From: Josh Carroll To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/121378: ushare should link to pthread in FreeBSD 7.0+ X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Mar 2008 04:10:01 -0000 >Number: 121378 >Category: ports >Synopsis: ushare should link to pthread in FreeBSD 7.0+ >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 05 04:10:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Josh Carroll >Release: 7.0-RELEASE >Organization: n/a >Environment: FreeBSD pflog.net 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Tue Feb 26 01:20:52 EST 2008 root@pflog.net:/usr/obj/usr/src/sys/PFLOG amd64 >Description: I have been tracking a problem with ushare when run on amd64/FreeBSD 7.0-RELEASE. Namely, when it is started with -D, it never listens on the upnp port/socket, and appears to hang in a pthread call. I filed a PR against libthr, but it turns out the solution is simply to compile ushare with -lpthread (or -pthread). This is done for other FreeBSD releases, so I am requesting that: .if ${OSVERSION} < 700042 CFLAGS+= ${PTHREAD_LIBS} .endif Be removed, so that all versions include -pthread: CFLAGS+= ${PTHREAD_LIBS} I have tested this and recompiling with the above changes fixes ushare when it is run as a daemon. Thanks! Josh >How-To-Repeat: - build and install ushare on amd64/FreeBSD 7.0 - run ushare -D - note the lack of listening socket in sockstat -4l output >Fix: The attached patch file just comments out the Patch attached with submission follows: --- Makefile 2008-03-04 23:02:05.000000000 -0500 +++ Makefile.new 2008-03-04 23:03:53.000000000 -0500 @@ -29,9 +29,7 @@ .include -.if ${OSVERSION} < 700042 CFLAGS+= ${PTHREAD_LIBS} -.endif do-install: ${INSTALL_SCRIPT} ${WRKSRC}/src/${PORTNAME} ${PREFIX}/bin >Release-Note: >Audit-Trail: >Unformatted: