From owner-svn-src-all@FreeBSD.ORG Fri Feb 14 01:27:16 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 97E6B793 for ; Fri, 14 Feb 2014 01:27:16 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7516A1A0E for ; Fri, 14 Feb 2014 01:27:16 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1E1RGBu059069 for ; Fri, 14 Feb 2014 01:27:16 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1E1RGIP059067 for svn-src-all@freebsd.org; Fri, 14 Feb 2014 01:27:16 GMT (envelope-from bdrewery) Received: (qmail 80477 invoked from network); 13 Feb 2014 19:27:11 -0600 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 13 Feb 2014 19:27:11 -0600 Message-ID: <52FD70E4.7080906@FreeBSD.org> Date: Thu, 13 Feb 2014 19:27:00 -0600 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Dimitry Andric , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r261801 - head/contrib/libc++/include References: <201402121814.s1CIEo5A016765@svn.freebsd.org> In-Reply-To: <201402121814.s1CIEo5A016765@svn.freebsd.org> X-Enigmail-Version: 1.6 OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U4xxIFlmWjId6nfxQHfJ689IpP8mlR1vv" Cc: FreeBSD Ports Management Team X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Feb 2014 01:27:16 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U4xxIFlmWjId6nfxQHfJ689IpP8mlR1vv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2/12/2014 12:14 PM, Dimitry Andric wrote: > Author: dim > Date: Wed Feb 12 18:14:49 2014 > New Revision: 261801 > URL: http://svnweb.freebsd.org/changeset/base/261801 >=20 > Log: > An ABI incompatibility crept into the libc++ 3.4 import in r261283. = It > was caused by upstream libc++ commit r194536, which aimed to make the= > headers more standards-compliant, by making std::pair's copy construc= tor > trivial. Unfortunately, this could cause certain C++ applications us= ing > shared libraries built against the previous version of libc++ to cras= h. > =20 > Fix the ABI incompatibility by making std::pair's copy constructor > non-trivial again. > =20 > Please note: Any C++ applications or shared libraries built with libc= ++ > between r261283 and this revision should be recompiled. *Please* bump __FreeBSD_version__ for ABI changes and notify portmgr@ of such cases that clearly affect package building. > =20 > Reported by: stefanf > MFC after: 3 weeks > X-MFC-With: r261283 >=20 > Modified: > head/contrib/libc++/include/__config >=20 > Modified: head/contrib/libc++/include/__config > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/contrib/libc++/include/__config Wed Feb 12 16:39:56 2014 (r261= 800) > +++ head/contrib/libc++/include/__config Wed Feb 12 18:14:49 2014 (r261= 801) > @@ -567,7 +567,7 @@ template struct __static_asse > #define _LIBCPP_WCTYPE_IS_MASK > #endif > =20 > -#if defined(__APPLE__) > +#if defined(__APPLE__) || defined(__FreeBSD__) > #ifndef _LIBCPP_TRIVIAL_PAIR_COPY_CTOR > # define _LIBCPP_TRIVIAL_PAIR_COPY_CTOR 0 > #endif >=20 --=20 Regards, Bryan Drewery --U4xxIFlmWjId6nfxQHfJ689IpP8mlR1vv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJS/XDkAAoJEDXXcbtuRpfPGVUH/2LJ9QettBvQJr2n0heMeJLm YM+MMdyIiU0bkOb/ORLyq7RHXn0lbSoPGe9/X5whsSuj7T+d7J8bd30iAiOF5As9 xLcZ0L3Sc6xOvlzjaQGEn+NIqbuP008UfhMpFRjUB15FHFVVYv+yKlfUI+dRmIWh FY826/J8V3SiuJlCrqZbnD6h7sKfM/ym5Oz6sCSP2DZ7IAJya9Ks/IJEtsyBx4Hz H43LZYbiEuuPdy91vSQDKGU5Q0yx5WVtqjHy3/MrAUZaHFHZ8cIcGV9uyES6Rs4A 1ThQZEo7cZkxCPvYnfv+eP+si6g/BbOPGEB/ndNigeD9G7tLeJ3bWe2TnJdhXzQ= =YEFk -----END PGP SIGNATURE----- --U4xxIFlmWjId6nfxQHfJ689IpP8mlR1vv--