Date: Thu, 13 Feb 2014 19:27:00 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: FreeBSD Ports Management Team <portmgr@FreeBSD.org> Subject: Re: svn commit: r261801 - head/contrib/libc++/include Message-ID: <52FD70E4.7080906@FreeBSD.org> In-Reply-To: <201402121814.s1CIEo5A016765@svn.freebsd.org> References: <201402121814.s1CIEo5A016765@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U4xxIFlmWjId6nfxQHfJ689IpP8mlR1vv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2/12/2014 12:14 PM, Dimitry Andric wrote: > Author: dim > Date: Wed Feb 12 18:14:49 2014 > New Revision: 261801 > URL: http://svnweb.freebsd.org/changeset/base/261801 >=20 > Log: > An ABI incompatibility crept into the libc++ 3.4 import in r261283. = It > was caused by upstream libc++ commit r194536, which aimed to make the= > headers more standards-compliant, by making std::pair's copy construc= tor > trivial. Unfortunately, this could cause certain C++ applications us= ing > shared libraries built against the previous version of libc++ to cras= h. > =20 > Fix the ABI incompatibility by making std::pair's copy constructor > non-trivial again. > =20 > Please note: Any C++ applications or shared libraries built with libc= ++ > between r261283 and this revision should be recompiled. *Please* bump __FreeBSD_version__ for ABI changes and notify portmgr@ of such cases that clearly affect package building. > =20 > Reported by: stefanf > MFC after: 3 weeks > X-MFC-With: r261283 >=20 > Modified: > head/contrib/libc++/include/__config >=20 > Modified: head/contrib/libc++/include/__config > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/contrib/libc++/include/__config Wed Feb 12 16:39:56 2014 (r261= 800) > +++ head/contrib/libc++/include/__config Wed Feb 12 18:14:49 2014 (r261= 801) > @@ -567,7 +567,7 @@ template <unsigned> struct __static_asse > #define _LIBCPP_WCTYPE_IS_MASK > #endif > =20 > -#if defined(__APPLE__) > +#if defined(__APPLE__) || defined(__FreeBSD__) > #ifndef _LIBCPP_TRIVIAL_PAIR_COPY_CTOR > # define _LIBCPP_TRIVIAL_PAIR_COPY_CTOR 0 > #endif >=20 --=20 Regards, Bryan Drewery --U4xxIFlmWjId6nfxQHfJ689IpP8mlR1vv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJS/XDkAAoJEDXXcbtuRpfPGVUH/2LJ9QettBvQJr2n0heMeJLm YM+MMdyIiU0bkOb/ORLyq7RHXn0lbSoPGe9/X5whsSuj7T+d7J8bd30iAiOF5As9 xLcZ0L3Sc6xOvlzjaQGEn+NIqbuP008UfhMpFRjUB15FHFVVYv+yKlfUI+dRmIWh FY826/J8V3SiuJlCrqZbnD6h7sKfM/ym5Oz6sCSP2DZ7IAJya9Ks/IJEtsyBx4Hz H43LZYbiEuuPdy91vSQDKGU5Q0yx5WVtqjHy3/MrAUZaHFHZ8cIcGV9uyES6Rs4A 1ThQZEo7cZkxCPvYnfv+eP+si6g/BbOPGEB/ndNigeD9G7tLeJ3bWe2TnJdhXzQ= =YEFk -----END PGP SIGNATURE----- --U4xxIFlmWjId6nfxQHfJ689IpP8mlR1vv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52FD70E4.7080906>