From owner-freebsd-bugs@FreeBSD.ORG Sat Nov 21 09:30:06 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37F1F1065676 for ; Sat, 21 Nov 2009 09:30:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 261A68FC12 for ; Sat, 21 Nov 2009 09:30:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nAL9U6V4006419 for ; Sat, 21 Nov 2009 09:30:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nAL9U69O006416; Sat, 21 Nov 2009 09:30:06 GMT (envelope-from gnats) Date: Sat, 21 Nov 2009 09:30:06 GMT Message-Id: <200911210930.nAL9U69O006416@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Paul Procacci Cc: Subject: Re: kern/140690: [libc] [patch] swab(3) with negative len should do nothing X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Paul Procacci List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Nov 2009 09:30:06 -0000 The following reply was made to PR kern/140690; it has been noted by GNATS. From: Paul Procacci To: , Cc: Subject: Re: kern/140690: [libc] [patch] swab(3) with negative len should do nothing Date: Sat, 21 Nov 2009 03:18:48 -0600 I'd like to add to this. As for the length argument. Is there really ever a time it would have to be signed? If not, then I would suggest declaring the type as size_t and not ssize_t much like the read/write/etc syscalls. ~Paul This message may contain confidential or privileged information. If you ar= e not the intended recipient, please advise us immediately and delete this = message. See http://www.datapipe.com/emaildisclaimer.aspx for further info= rmation on confidentiality and the risks of non-secure electronic communica= tion. If you cannot access these links, please notify us by reply message a= nd we will send the contents to you.