From owner-cvs-ports@FreeBSD.ORG  Thu Oct 30 03:04:09 2003
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AA42916A4CE
	for <cvs-ports@FreeBSD.org>; Thu, 30 Oct 2003 03:04:09 -0800 (PST)
Received: from mx2.fillmore-labs.com (lima.fillmore-labs.com [62.138.193.83])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9818643F3F
	for <cvs-ports@FreeBSD.org>; Thu, 30 Oct 2003 03:04:08 -0800 (PST)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from p5080afbd.dip.t-dialin.net
	([80.128.175.189] helo=fillmore-labs.com ident=kvtbtryatzt14gqu)
	by mx2.fillmore-labs.com with asmtp (TLSv1:AES256-SHA:256)
	(Exim 4.24; FreeBSD 4.9)
	id 1AFAay-0008jG-6y; Thu, 30 Oct 2003 12:04:04 +0100
Message-ID: <3FA0F01E.5040107@fillmore-labs.com>
Date: Thu, 30 Oct 2003 12:03:58 +0100
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
MIME-Version: 1.0
To: Trevor Johnson <trevor@jpj.net>
References: <200310292246.h9TMkjSI062232@repoman.freebsd.org>
	<3FA05A25.2020408@fillmore-labs.com>
	<20031030013046.26bb944c.sheepkiller@cultdeadsheep.org>
	<20031029233231.V7442@blues.jpj.net>
In-Reply-To: <20031029233231.V7442@blues.jpj.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Authenticated-Sender: eikemeier@fillmore-labs.com
User-Agent: KMail/1.5.9
Organization: Fillmore Labs GmbH  <http://www.fillmore-labs.com/>
X-Complaints-To: abuse@fillmore-labs.com
cc: cvs-ports@FreeBSD.org
cc: Clement Laforet <sheepkiller@cultdeadsheep.org>
Subject: Re: cvs commit: ports/www/apache2
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Oct 2003 11:04:09 -0000

Trevor Johnson wrote:

> Clement Laforet wrote:
> 
>>Oliver Eikemeier <eikemeier@fillmore-labs.com> wrote:
>>
>>>WITH_HTTP_PORT, WITHOUT_CGI, WITHOUT_ICONS wouldn't be that bad...
> 
> [...]
> 
>>You're right... I'll correct it with PORTREVISION 1, with future changes
>>in Makefile.modules.
> 
> I had thought of the same thing, but I was in a hurry.  How's this:
> <URL:http://people.freebsd.org/~trevor/ports/apache2-cosmetic.diff>?

I really don't want to be portlint, but hey, you asked for it:

> +CONFLICTS=	apache+ipv6-1.* \
> +		apache+modssl-1.* \
> +		apache+ssl-1.* \
> +		apache-1.* \
> +		apache_fp-1.* \
> +		caudium-devel-1.* \
> +		caudium10-1.* \
> +		caudium12-* \
> +		ru-apache+mod_ssl-1.* \
> +		ru-apache-1.* \
> +		thttpd-2.*
> +

I can't find any conflicts with the caudium* ports, and www/mini_httpd
is missing. How about:

+CONFLICTS=	apache+ipv6-1.* \
+		apache+modssl-1.* \
+		apache+ssl-1.* \
+		apache-1.* \
+		apache_fp-1.* \
+		mini_httpd-1.* \
+		ru-apache+mod_ssl-1.* \
+		ru-apache-1.* \
+		thttpd-2.*


> +#	WITH_PORT                default: 80

I'm fine with that, even though WITH_HTTP_PORT seems more appealing to me.


> +#	WITHOUT_ERROR:            Do not install www/error

I would make this the default ;-) Honestly: there must be a better name
for it. Do we need that many options?


> .if defined(WITH_LDAP)
> USE_LDAP=	YES

That doesn't seem to work, it's USE_OPENLDAP as far as I can remember.


> +	@${ECHO}
> +	@${ECHO_MSG} "*** To see all available knobs, type:  make show-options"
> +	@${ECHO}
Mixing ECHO and ECHO_MSG is strange, how about using ECHO here?


> show-options:
> 	@${EGREP} '^##' ${.CURDIR}/Makefile | ${SED} 's/##//'

Not that I particularly like this, but how about using:
	@${SED} -ne 's/^##//p' ${.CURDIR}/Makefile