From owner-svn-src-head@freebsd.org Thu Jul 26 17:15:53 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99F5C105541F for ; Thu, 26 Jul 2018 17:15:53 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0081C70E59 for ; Thu, 26 Jul 2018 17:15:52 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-wr1-x444.google.com with SMTP id h9-v6so2466067wro.3 for ; Thu, 26 Jul 2018 10:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IwWEA/dj8ziqPAv+0+m++CSkX98rMZaJaB4azMkwg40=; b=bTP/npLQiP8TJgmT8wB8X+vmw+ev+o/8kRnZOQXT78lYcRswtn4pmfd3LiQqOt7k7J HnQZBHvv6XGV8ZrzVlZ0HywW8jvqzxSn7eguqlSm7pV3WYgrlElTYFW58Zmu7Ot/7dET dbPyA23cgR9mxuYVIHWHwzBak6+KsQv8LDPLK4EI6Edqe+wCiK6aByzEpZL0rT07a/VV yDw6ZNF74A/zmz72Bjnh7lW7kBjJqIZQe2WsDP+VEeuplPPUM98UB1me6u8rU33Vt+cQ +BEVNs8vFSfj43POFQvPEfrkbLgklWv8SQqmVOa9uCes1RFtSNkhzgu0/iYbswuqrbxy ul2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IwWEA/dj8ziqPAv+0+m++CSkX98rMZaJaB4azMkwg40=; b=oycqWBLVQiUfz+EZNKsB/5/oYOtalaqKpi0GyU/dAtE4TV/f5M6rmyQzZLh0cvwQZw TZpBIAMzR+Z3gWFcRaNg876x729KTDXP9mnbTfJ2pYsiMP5iv7il2mxIWwsfNsVVxVzc kKjm/VahDYabSQDYCFXZXtIAkJSvDdWWCmC/OLsgCYDCDy8gDGgrsw+gZV69cSx9syxY lR3YwH/CVN9dr1226FLWtVwZNgevdLwPfyXHvpL6/LqGH08r8bhaIf6OS2T6jqyJOuN7 UYJvbNsC0yXl0yqfxGWjl41in5blW6mmq7RTx0+EhiJwAKLUlveOsC4YXpwCeHgLqids JkVQ== X-Gm-Message-State: AOUpUlFPSVGU/eR0IIJtKcmXdmDWOQjrjjLPOeZFXvHOZhyowBUGR6lv 1VZFpAbVcd+Niq6G8Lehk7Az06jf7JPEJQ== X-Google-Smtp-Source: AAOMgpcj5S+BYEUlQa2mtaDjwgpqvDAoSi1Y21h/qMGHZ3MtUAwHy2YAzsbeokgNoFbDR6zukqJjVQ== X-Received: by 2002:a5d:4643:: with SMTP id j3-v6mr2218351wrs.52.1532625351861; Thu, 26 Jul 2018 10:15:51 -0700 (PDT) Received: from mutt-hbsd ([185.220.102.8]) by smtp.gmail.com with ESMTPSA id v5-v6sm3583969wrp.87.2018.07.26.10.15.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 10:15:51 -0700 (PDT) Date: Thu, 26 Jul 2018 13:15:11 -0400 From: Shawn Webb To: Brad Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk Message-ID: <20180726171511.fysn3u5la2l2t3ht@mutt-hbsd> References: <201807261705.w6QH5Y1D034822@repo.freebsd.org> <20180726170900.twg3qeh34wmaerul@mutt-hbsd> <1532625065.2234037.1453936096.39AD7179@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nlttwvream3k6wiz" Content-Disposition: inline In-Reply-To: <1532625065.2234037.1453936096.39AD7179@webmail.messagingengine.com> X-Operating-System: FreeBSD mutt-hbsd 12.0-CURRENT FreeBSD 12.0-CURRENT X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20180622 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 17:15:53 -0000 --nlttwvream3k6wiz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 26, 2018 at 11:11:05AM -0600, Brad Davis wrote: > On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote: > > On Thu, Jul 26, 2018 at 05:05:34PM +0000, Brad Davis wrote: > > > Author: brd > > > Date: Thu Jul 26 17:05:33 2018 > > > New Revision: 336744 > > > URL: https://svnweb.freebsd.org/changeset/base/336744 > > >=20 > > > Log: > > > Convert bsd.files.mk to support DIRS and simplify by only having on= e install > > > target. > > > =20 > > > Also update the pfctl tests Makefile to work with this change. > > > =20 > > > Approved by: bapt (mentor) > > > Differential Revision: https://reviews.freebsd.org/D16430 > > >=20 > > > Modified: > > > head/sbin/pfctl/tests/files/Makefile > > > head/share/mk/bsd.files.mk > > >=20 > > > Modified: head/sbin/pfctl/tests/files/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/sbin/pfctl/tests/files/Makefile Thu Jul 26 16:51:23 2018 (r3= 36743) > > > +++ head/sbin/pfctl/tests/files/Makefile Thu Jul 26 17:05:33 2018 (r3= 36744) > > > @@ -4,9 +4,7 @@ TESTSDIR=3D ${TESTSBASE}/sbin/pfctl/files > > > BINDIR=3D ${TESTSDIR} > > > =20 > > > # We use ${.CURDIR} as workaround so that the glob patterns work. > > > -FILES=3D ${.CURDIR}/pf????.in > > > -FILES+=3D ${.CURDIR}/pf????.include > > > -FILES+=3D ${.CURDIR}/pf????.ok > > > +FILES!=3D echo ${.CURDIR}/pf????.in ${.CURDIR}/pf????.include ${.CU= RDIR}/pf????.ok > >=20 > > Should this use ${ECHO} instead of echo? >=20 > No, that wouldn't work at all with the !=3D. I thought that might be the case, but I just wanted to make sure. Thanks for the clarification. --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --nlttwvream3k6wiz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAltaAZ8ACgkQaoRlj1JF bu5PFg//emYQVZjVR+Kd4f7b/EkIh8yqGHCo/qM3jqwxOGMPjBcyeQFcTqj8CCKR RumK8ZQfcxgWuDiGe4C2sroYgiAQaW1bdN9eXwH6qBC5ju7UI4gHTti48p41q0ik nO26ifpeONyE8CxwryxJh036HIBkNZwInm5fRLGoo29Qe0J76PUSzmtb8Lzrovyg r/9pLeDF56qg268y0HmkHuPFLKI9sNOx2wJYUvjNF36UE3E+zWTqxGO6EhKmwF7U ZRJmXEhSclSylLuQpQIhKuoOJlrDPHlnQvsOaSLDj/DIN/iXehBXweYO7/O9TWli r1AKFU45rZi4oR9jXUeicBFRNhPUd2UZ7fR7j5mN8qBvb41vNMBI6KeS5F9cWz9L lw7wOhje0k001LiNwI7h64PaEXOFibaAfntLstAG3wfuQ02/U5iTN2+burQ3//6V AUmInsuR0xiNgATfP3sdZ9iRHE/Ji3LYuXh20/AWN4VAgWVyB0wdPvltwxQvEwDI AdOmAzRviw0jJ2YF9myOPf86tcbhOXBe/JM+Ol7/o0DZq3sI90M0gAjfYG8LVsll 0NHyFNprKjeE2BdO9ahn/6QUC7fF1mff1NVTcy8YvOFtpqZgV14Kf1aYMP57s1bP VVmJy3il8EU6X8svtnw/nRzrFezGJ+oUeK1XgZUW6EQYCJ1Cq5s= =5Ms6 -----END PGP SIGNATURE----- --nlttwvream3k6wiz--