Date: Thu, 26 Jul 2018 13:15:11 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Brad Davis <brd@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk Message-ID: <20180726171511.fysn3u5la2l2t3ht@mutt-hbsd> In-Reply-To: <1532625065.2234037.1453936096.39AD7179@webmail.messagingengine.com> References: <201807261705.w6QH5Y1D034822@repo.freebsd.org> <20180726170900.twg3qeh34wmaerul@mutt-hbsd> <1532625065.2234037.1453936096.39AD7179@webmail.messagingengine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nlttwvream3k6wiz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 26, 2018 at 11:11:05AM -0600, Brad Davis wrote: > On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote: > > On Thu, Jul 26, 2018 at 05:05:34PM +0000, Brad Davis wrote: > > > Author: brd > > > Date: Thu Jul 26 17:05:33 2018 > > > New Revision: 336744 > > > URL: https://svnweb.freebsd.org/changeset/base/336744 > > >=20 > > > Log: > > > Convert bsd.files.mk to support DIRS and simplify by only having on= e install > > > target. > > > =20 > > > Also update the pfctl tests Makefile to work with this change. > > > =20 > > > Approved by: bapt (mentor) > > > Differential Revision: https://reviews.freebsd.org/D16430 > > >=20 > > > Modified: > > > head/sbin/pfctl/tests/files/Makefile > > > head/share/mk/bsd.files.mk > > >=20 > > > Modified: head/sbin/pfctl/tests/files/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/sbin/pfctl/tests/files/Makefile Thu Jul 26 16:51:23 2018 (r3= 36743) > > > +++ head/sbin/pfctl/tests/files/Makefile Thu Jul 26 17:05:33 2018 (r3= 36744) > > > @@ -4,9 +4,7 @@ TESTSDIR=3D ${TESTSBASE}/sbin/pfctl/files > > > BINDIR=3D ${TESTSDIR} > > > =20 > > > # We use ${.CURDIR} as workaround so that the glob patterns work. > > > -FILES=3D ${.CURDIR}/pf????.in > > > -FILES+=3D ${.CURDIR}/pf????.include > > > -FILES+=3D ${.CURDIR}/pf????.ok > > > +FILES!=3D echo ${.CURDIR}/pf????.in ${.CURDIR}/pf????.include ${.CU= RDIR}/pf????.ok > >=20 > > Should this use ${ECHO} instead of echo? >=20 > No, that wouldn't work at all with the !=3D. I thought that might be the case, but I just wanted to make sure. Thanks for the clarification. --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --nlttwvream3k6wiz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAltaAZ8ACgkQaoRlj1JF bu5PFg//emYQVZjVR+Kd4f7b/EkIh8yqGHCo/qM3jqwxOGMPjBcyeQFcTqj8CCKR RumK8ZQfcxgWuDiGe4C2sroYgiAQaW1bdN9eXwH6qBC5ju7UI4gHTti48p41q0ik nO26ifpeONyE8CxwryxJh036HIBkNZwInm5fRLGoo29Qe0J76PUSzmtb8Lzrovyg r/9pLeDF56qg268y0HmkHuPFLKI9sNOx2wJYUvjNF36UE3E+zWTqxGO6EhKmwF7U ZRJmXEhSclSylLuQpQIhKuoOJlrDPHlnQvsOaSLDj/DIN/iXehBXweYO7/O9TWli r1AKFU45rZi4oR9jXUeicBFRNhPUd2UZ7fR7j5mN8qBvb41vNMBI6KeS5F9cWz9L lw7wOhje0k001LiNwI7h64PaEXOFibaAfntLstAG3wfuQ02/U5iTN2+burQ3//6V AUmInsuR0xiNgATfP3sdZ9iRHE/Ji3LYuXh20/AWN4VAgWVyB0wdPvltwxQvEwDI AdOmAzRviw0jJ2YF9myOPf86tcbhOXBe/JM+Ol7/o0DZq3sI90M0gAjfYG8LVsll 0NHyFNprKjeE2BdO9ahn/6QUC7fF1mff1NVTcy8YvOFtpqZgV14Kf1aYMP57s1bP VVmJy3il8EU6X8svtnw/nRzrFezGJ+oUeK1XgZUW6EQYCJ1Cq5s= =5Ms6 -----END PGP SIGNATURE----- --nlttwvream3k6wiz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180726171511.fysn3u5la2l2t3ht>